Fix PyJuju sandbox remove relation tests.

Fix PyJuju sandbox remove relation tests.

Fix some broken tests in the PyJuju sandbox, namely the relation removal
ones that call the generateAndRelateServices utility function.

https://code.launchpad.net/~teknico/juju-gui/fix-pyjuju-sandbox-tests/+merge/171769

(do not edit description out of merge proposal)

[teknico, 2013-06-27 10:52:33]

Please take a look.

[frankban, 2013-06-27 11:20:15]

LGTM with trivial changes and one question, see below.
Thank you Nicola!

https://codereview.appspot.com/10677043/diff/1/test/test_sandbox.js
File test/test_sandbox.js (right):

https://codereview.appspot.com/10677043/diff/1/test/test_sandbox.js#newcode258
test/test_sandbox.js:258: @param {Array} charms Two strings with the charm ids
to be deployed.
Optional: maybe it is clearer if we call these "charm URLs".

https://codereview.appspot.com/10677043/diff/1/test/test_sandbox.js#newcode259
test/test_sandbox.js:259: @param {Array} relation Two strings with the charm ids
to be related.
It seems that relation is an array of two strings each one representing a
relation endpoint, not a charm id, e.g. 'service-name:relation-name' or similar.

https://codereview.appspot.com/10677043/diff/1/test/test_sandbox.js#newcode260
test/test_sandbox.js:260: @param {Array} removeRelation Two strings with the
charm ids that
Same as above.

https://codereview.appspot.com/10677043/diff/1/test/test_sandbox.js#newcode1294
test/test_sandbox.js:1294: ['no_such', 'charms'],
The third argument should describe the relation to be removed. I know this
pre-existed, but I am confused about what we are actually testing here. Trying
to remove a not existing relation? Passing invalid endpoints? Or a relation
between two not existing services? The error "Charm not loaded" also does not
help a lot.

[teknico, 2013-06-27 11:30:32]

Changed the doc comment according to comments, thanks.

https://codereview.appspot.com/10677043/diff/1/test/test_sandbox.js
File test/test_sandbox.js (right):

https://codereview.appspot.com/10677043/diff/1/test/test_sandbox.js#newcode258
test/test_sandbox.js:258: @param {Array} charms Two strings with the charm ids
to be deployed.
frankban wrote:
> Optional: maybe it is clearer if we call these "charm URLs". 

Right.

https://codereview.appspot.com/10677043/diff/1/test/test_sandbox.js#newcode1294
test/test_sandbox.js:1294: ['no_such', 'charms'],
frankban wrote:
> The third argument should describe the relation to be removed.
> I know this pre-existed, but I am confused about what we are
> actually testing here. Trying to remove a not existing relation?

No, that's tested by the next test.

> Passing invalid endpoints? Or a relation between two not
> existing services?

Not sure about the distinction between these two cases.

> The error "Charm not loaded" also does not help a lot.

Indeed.

[teknico, 2013-06-27 11:33:31]

Please take a look.

[benji, 2013-06-27 13:45:46]

LGTM

[teknico, 2013-06-27 14:43:24]

*** Submitted:

Fix PyJuju sandbox remove relation tests.

Fix some broken tests in the PyJuju sandbox, namely the relation removal
ones that call the generateAndRelateServices utility function.

R=frankban, benji
CC=
https://codereview.appspot.com/10677043