Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(537)

Issue 106750044: Fix root-disk consraints on ec2

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by wallyworld
Modified:
9 years, 10 months ago
Reviewers:
mp+221664
Visibility:
Public.

Description

Fix root-disk consraints on ec2 EC2 instance types do not include a root disk size as this is set on instance creation. This was causing the contraints matching to fail when root disk was specified. The fix is to ignore 0 root disk values when matching constraints. https://code.launchpad.net/~wallyworld/juju-core/ec2-root-disk-constraint/+merge/221664 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/instances/instancetype.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/instances/instancetype_test.go View 4 chunks +0 lines, -4 lines 0 comments Download
M provider/ec2/image_test.go View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1
wallyworld
9 years, 10 months ago (2014-06-02 05:54:30 UTC) #1
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b