code review 106320043: codereview: abort 'hg commit' before entering commit me...

codereview: abort 'hg commit' before entering commit message.

Hook pre-commit runs before 'hg commit' command whereas hook precommit runs
after the user has entered commit message.

[minux, 2014-06-30 18:29:31]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2014-06-30 18:53:21]

And where does uisetup run?

[rsc, 2014-06-30 21:26:56]

LGTM

[minux, 2014-07-19 01:04:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=26ba1fd4913d ***

codereview: abort 'hg commit' before entering commit message.

Hook pre-commit runs before 'hg commit' command whereas hook precommit runs
after the user has entered commit message.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/106320043

[gobot, 2014-07-19 02:07:06]

This CL appears to have broken the linux-arm-cheney-imx6 builder.
See http://build.golang.org/log/0b43245352ede392671b5e105a303e85881f1398

[minux, 2014-07-19 02:14:14]

On Fri, Jul 18, 2014 at 10:07 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-arm-cheney-imx6 builder.
> See http://build.golang.org/log/0b43245352ede392671b5e105a303e85881f1398

Looks real, but this change definitely won't cause that.

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestCgoCrashHandler (0.61s)
crash_test.go:86: output:
  wanted:
main: recovered done
new-thread: recovered done
 second-new-thread: recovered done
main-again: recovered done
FAIL
FAIL runtime 109.351s