Issue 10630043: code review 10630043: crypto/sha512: provide top-level Sum512 and Sum384 functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10630043: code review 10630043: crypto/sha512: provide top-level Sum512 and Sum384 functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by r

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

crypto/sha512: provide top-level Sum512 and Sum384 functions Makes it easy to ask the simple question, what is the hash of this data? Also fix the commentary and prints in Sum256.

Patch Set 1 #

Patch Set 2 : diff -r edd229b63fa4 https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -5 lines)			Patch
M	src/pkg/crypto/sha256/sha256.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/sha256/sha256_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/sha512/sha512.go	View	3 chunks	+27 lines, -3 lines	0 comments	Download
M	src/pkg/crypto/sha512/sha512_test.go	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-06-26 18:42:52 UTC) #1

11 years, 7 months ago (2013-06-26 20:14:17 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=65e2aba21abe ***

crypto/sha512: provide top-level Sum512 and Sum384 functions
Makes it easy to ask the simple question, what is the hash of this data?
Also fix the commentary and prints in Sum256.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/10630043

Expand All Messages | Collapse All Messages