Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(190)

Issue 10630043: code review 10630043: crypto/sha512: provide top-level Sum512 and Sum384 functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by r
Modified:
4 years, 4 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

crypto/sha512: provide top-level Sum512 and Sum384 functions Makes it easy to ask the simple question, what is the hash of this data? Also fix the commentary and prints in Sum256.

Patch Set 1 #

Patch Set 2 : diff -r edd229b63fa4 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M src/pkg/crypto/sha256/sha256.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/sha256/sha256_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/sha512/sha512.go View 3 chunks +27 lines, -3 lines 0 comments Download
M src/pkg/crypto/sha512/sha512_test.go View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
4 years, 4 months ago (2013-06-26 18:42:52 UTC) #1
rsc
LGTM
4 years, 4 months ago (2013-06-26 19:48:47 UTC) #2
r
4 years, 4 months ago (2013-06-26 20:14:17 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=65e2aba21abe ***

crypto/sha512: provide top-level Sum512 and Sum384 functions
Makes it easy to ask the simple question, what is the hash of this data?
Also fix the commentary and prints in Sum256.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/10630043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4