Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1069)

Issue 10629043: code review 10629043: crypto/sha245: provide top-level Sum and Sum224 functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by r
Modified:
10 years, 9 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

crypto/sha256: provide top-level Sum and Sum224 functions Makes it easy to ask the simple question, what is the hash of this data?

Patch Set 1 #

Patch Set 2 : diff -r 2aa1e39979fa https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M src/pkg/crypto/sha256/sha256.go View 3 chunks +28 lines, -4 lines 0 comments Download
M src/pkg/crypto/sha256/sha256_test.go View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 9 months ago (2013-06-26 18:30:21 UTC) #1
rsc
LGTM - s/245/256/ in CL desc
10 years, 9 months ago (2013-06-26 18:34:28 UTC) #2
r
10 years, 9 months ago (2013-06-26 18:36:21 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=edd229b63fa4 ***

crypto/sha256: provide top-level Sum and Sum224 functions
Makes it easy to ask the simple question, what is the hash of this data?

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/10629043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b