Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(188)

Issue 10624044: code review 10624044: crypto/md5: provide a top-level Sum function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by r
Modified:
4 years, 4 months ago
Reviewers:
agl1
CC:
golang-dev, agl1
Visibility:
Public.

Description

crypto/md5: provide a top-level Sum function Makes it easy to ask the simple question, what is the hash of this data? Also mark block as non-escaping.

Patch Set 1 #

Patch Set 2 : diff -r 4724e59b3b85 https://code.google.com/p/go #

Patch Set 3 : diff -r 4724e59b3b85 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/pkg/crypto/md5/md5.go View 1 2 chunks +13 lines, -1 line 0 comments Download
M src/pkg/crypto/md5/md5_test.go View 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/crypto/md5/md5block_decl.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
4 years, 4 months ago (2013-06-26 18:11:13 UTC) #1
agl1
LGTM
4 years, 4 months ago (2013-06-26 18:25:30 UTC) #2
r
4 years, 4 months ago (2013-06-26 18:29:37 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=d4e29abfb2e0 ***

crypto/md5: provide a top-level Sum function
Makes it easy to ask the simple question, what is the hash of this data?
Also mark block as non-escaping.

R=golang-dev, agl
CC=golang-dev
https://codereview.appspot.com/10624044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4