Issue 10622043: code review 10622043: go.tools/ssa: emit ChangeType when using method as func...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10622043: code review 10622043: go.tools/ssa: emit ChangeType when using method as func... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by adonovan

Modified:
12 years, 9 months ago

Reviewers:
gri

CC:
gri, golang-dev

Visibility:
Public.

Description

go.tools/ssa: emit ChangeType when using method as function in f := T.meth. Previously: typeOf(f).Signature.Recv == T Now: typeOf(f).Signature.Params.At(0) == T Added test. BUG=5781

Patch Set 1 #

Patch Set 2 : diff -r 35cadadd0c32 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 35cadadd0c32 https://code.google.com/p/go.tools #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
M	ssa/builder.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ssa/emit.go	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	ssa/interp/testdata/boundmeth.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 9 months ago (2013-06-26 17:18:29 UTC) #2

adonovan

12 years, 9 months ago (2013-06-26 17:18:33 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=43cab0702d88&repo=tools ***

go.tools/ssa: emit ChangeType when using method as function in f := T.meth.

Previously: typeOf(f).Signature.Recv == T
       Now: typeOf(f).Signature.Params.At(0) == T

Added test.

BUG=5781

R=gri
CC=golang-dev
https://codereview.appspot.com/10622043

Expand All Messages | Collapse All Messages