Issue 106180046: Log traceback where Future, Task and Handle are created in error messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 106180046: Log traceback where Future, Task and Handle are created in error messages

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by haypo_gmail

Modified:
9 years, 10 months ago

Reviewers:
yselivanov

Visibility:
Public.

More Reviews

Description

Log traceback where Future, Task and Handle are created in error messages

Patch Set 1 #

Total comments: 2

Patch Set 2 : Truncate Handle traceback to hide internal calls #

Total comments: 1

Patch Set 3 : more tests, _truncate_source_traceback() function #

Patch Set 4 : inline _truncate�_source_traceback #

Total comments: 5

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -22 lines)			Patch
M	asyncio/base_events.py	View	1 2 3	7 chunks	+22 lines, -3 lines	1 comment	Download
M	asyncio/events.py	View	1 2 3	5 chunks	+14 lines, -4 lines	0 comments	Download
M	asyncio/futures.py	View		5 chunks	+13 lines, -4 lines	0 comments	Download
M	asyncio/tasks.py	View	1 2 3	3 chunks	+11 lines, -3 lines	0 comments	Download
M	tests/test_base_events.py	View	1 2 3	1 chunk	+6 lines, -3 lines	0 comments	Download
M	tests/test_events.py	View	1 2	3 chunks	+38 lines, -3 lines	1 comment	Download
M	tests/test_futures.py	View	1 2	2 chunks	+13 lines, -0 lines	1 comment	Download
M	tests/test_tasks.py	View	1 2	3 chunks	+18 lines, -2 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

yselivanov

Victor, I like the new patch! There are couple of small issues, mostly around unitttests... ...

9 years, 10 months ago (2014-06-25 23:36:53 UTC) #1

haypo_gmail

9 years, 10 months ago (2014-06-26 22:56:09 UTC) #2

https://codereview.appspot.com/106180046/diff/60001/asyncio/base_events.py
File asyncio/base_events.py (right):

https://codereview.appspot.com/106180046/diff/60001/asyncio/base_events.py#ne...
asyncio/base_events.py:776: value = 'most recent call last:\n  ' + tb.strip()
the message can be:
value = 'object created at (most recent call last):'

https://codereview.appspot.com/106180046/diff/60001/tests/test_events.py
File tests/test_events.py (right):

https://codereview.appspot.com/106180046/diff/60001/tests/test_events.py#newc...
tests/test_events.py:1848: tb = h._source_traceback
tb variable is useless, h._source_traceback can be used directly.

https://codereview.appspot.com/106180046/diff/60001/tests/test_futures.py
File tests/test_futures.py (right):

https://codereview.appspot.com/106180046/diff/60001/tests/test_futures.py#new...
tests/test_futures.py:293: tb = future._source_traceback
tb variable is useless, h._source_traceback can be used directly.

https://codereview.appspot.com/106180046/diff/60001/tests/test_tasks.py
File tests/test_tasks.py (right):

https://codereview.appspot.com/106180046/diff/60001/tests/test_tasks.py#newco...
tests/test_tasks.py:1572: context['source_traceback'] = source_traceback
It can be moved in the dict.

https://codereview.appspot.com/106180046/diff/60001/tests/test_tasks.py#newco...
tests/test_tasks.py:1581: tb = future._source_traceback
tb variable is useless, h._source_traceback can be used directly.

Expand All Messages | Collapse All Messages