Issue 106140043: Fixed footer to bottom of the page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 106140043: Fixed footer to bottom of the page (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by ajgupta93

Modified:
9 years, 9 months ago

Reviewers:
thomas.j.waldmann, RogerHaase

Visibility:
Public.

More Reviews

Patch Set 2 : Shifted code sections in main.styl as per last comment #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -3 lines)			Patch
M	MoinMoin/themes/basic/static/css/basic.css	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	MoinMoin/themes/basic/static/custom-less/basic.less	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	MoinMoin/themes/basic/templates/layout.html	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	MoinMoin/themes/foobar/static/css/common.css	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	MoinMoin/themes/foobar/static/css/stylus/main.styl	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	MoinMoin/themes/modernized/static/css/common.css	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	MoinMoin/themes/modernized/static/css/stylus/main.styl	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

source looks mostly ok, see that one place i commented. https://codereview.appspot.com/106140043/diff/1/MoinMoin/themes/foobar/static/css/common.css File MoinMoin/themes/foobar/static/css/common.css (right): https://codereview.appspot.com/106140043/diff/1/MoinMoin/themes/foobar/static/css/common.css#newcode453 ...

9 years, 10 months ago (2014-06-24 17:16:34 UTC) #1

RogerHaase

https://codereview.appspot.com/106140043/diff/1/MoinMoin/themes/foobar/static/css/common.css File MoinMoin/themes/foobar/static/css/common.css (right): https://codereview.appspot.com/106140043/diff/1/MoinMoin/themes/foobar/static/css/common.css#newcode456 MoinMoin/themes/foobar/static/css/common.css:456: #moin-footer{position:absolute;bottom:5px;width:98%} above will be fixed by moving this above ...

9 years, 10 months ago (2014-06-24 17:42:19 UTC) #2

RogerHaase

https://codereview.appspot.com/106140043/diff/1/MoinMoin/themes/foobar/static/css/stylus/main.styl File MoinMoin/themes/foobar/static/css/stylus/main.styl (right): https://codereview.appspot.com/106140043/diff/1/MoinMoin/themes/foobar/static/css/stylus/main.styl#newcode1180 MoinMoin/themes/foobar/static/css/stylus/main.styl:1180: width 98% put my earlier comment in wrong place ...

9 years, 10 months ago (2014-06-24 17:44:35 UTC) #3

looks OK, commit

Expand All Messages | Collapse All Messages