Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2588)

Issue 106120043: Add homebrew release instructions.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by bac
Modified:
9 years, 10 months ago
Reviewers:
mp+223601, frankban
Visibility:
Public.

Description

Add homebrew release instructions. Also fixed bad coding in HACKING.rst. Used the 'restview' package from PyPI to verify it. Replaced long embedded URLs with references. Looks very nice if rendered but not as good if read as plaintext. https://code.launchpad.net/~bac/juju-quickstart/hacking-brew/+merge/223601 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 7

Patch Set 2 : Add homebrew release instructions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -18 lines) Patch
M HACKING.rst View 1 4 chunks +84 lines, -18 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bac
Please take a look.
9 years, 10 months ago (2014-06-18 16:04:17 UTC) #1
frankban
LGTM with minor changes. Thank you! https://codereview.appspot.com/106120043/diff/1/HACKING.rst File HACKING.rst (right): https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode215 HACKING.rst:215: #. Compute the ...
9 years, 10 months ago (2014-06-18 16:17:25 UTC) #2
bac
9 years, 10 months ago (2014-06-18 17:50:49 UTC) #3
*** Submitted:

Add homebrew release instructions.

Also fixed bad coding in HACKING.rst.  Used the 'restview'
package from PyPI to verify it.  Replaced long embedded
URLs with references.  Looks very nice if rendered but
not as good if read as plaintext.

R=frankban
CC=
https://codereview.appspot.com/106120043

https://codereview.appspot.com/106120043/diff/1/HACKING.rst
File HACKING.rst (right):

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode215
HACKING.rst:215: #. Compute the SHA1 checksum for the tgz and insert it as the
JujuQuickstart
On 2014/06/18 16:17:24, frankban wrote:
> Juju Quickstart?

Actually brew constructs a Ruby class based on the package name, so in the file
it really is JujuQuickstart.

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode221
HACKING.rst:221: download failures are acceptable.)::
On 2014/06/18 16:17:25, frankban wrote:
> are acceptable)

Done.

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode221
HACKING.rst:221: download failures are acceptable.)::
On 2014/06/18 16:17:25, frankban wrote:
> are acceptable)

Done.

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode252
HACKING.rst:252: rebase the branch and squash commits before pushing.
I will.  This update was flawless and when Jenkins passed the bot merged it in. 
Total time was about two hours.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b