Issue 106110043: Added create ticket button

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 106110043: Added create ticket button

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by sksaurabhkathpalia

Modified:
9 years, 10 months ago

Reviewers:
dimazest

Visibility:
Public.

More Reviews

Description

Added create ticket button

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -7 lines)			Patch
M	MoinMoin/items/__init__.py	View	3 chunks	+11 lines, -3 lines	1 comment	Download
M	MoinMoin/items/ticket.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	MoinMoin/templates/ticket/modify.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	MoinMoin/templates/ticket/submit.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	MoinMoin/templates/tickets.html	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	MoinMoin/util/notifications.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

dimazest

9 years, 10 months ago (2014-06-17 20:29:01 UTC) #1

https://codereview.appspot.com/106110043/diff/1/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

https://codereview.appspot.com/106110043/diff/1/MoinMoin/items/__init__.py#ne...
MoinMoin/items/__init__.py:541: # For Ticket items as these don't have any
initial fqname so just using a temporary name as itemtype
so, this is a very general code, and you already make an assumption that there
are special "ticket" items.

this code, ideally, should not know about this.

secondly, there might be a concurrency issue, what if two new items are created
at the same time? then the name won't be unique.

Expand All Messages | Collapse All Messages