Issue 10610043: Update charm token tests to clean up instances.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10610043: Update charm token tests to clean up instances.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rharding

Modified:
12 years ago

Reviewers:
mp+171543, benji

Visibility:
Public.

Description

Update charm token tests to clean up instances. - Make sure we tear down instances created. - Mechanical changes to match names of instances with the cleaned up var https://code.launchpad.net/~rharding/juju-gui/token-tests/+merge/171543 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update charm token tests to clean up instances. #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -19 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	test/test_charm_token.js	View		5 chunks	+22 lines, -19 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benji

This is a big improvement. I did something similar in my branch so +1. LGTM-ly ...

12 years ago (2013-06-26 13:18:04 UTC) #2

rharding

12 years ago (2013-06-26 13:25:00 UTC) #3

*** Submitted:

Update charm token tests to clean up instances.

- Make sure we tear down instances created.
- Mechanical changes to match names of instances with the cleaned up var

R=benji
CC=
https://codereview.appspot.com/10610043

Expand All Messages | Collapse All Messages