Issue 10605043: Add/remove relations in juju-core sandbox.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10605043: Add/remove relations in juju-core sandbox.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by teknico

Modified:
12 years ago

Reviewers:
frankban, mp+171514, gary.poster

Visibility:
Public.

Description

Add/remove relations in juju-core sandbox. Implement add/remove relations in juju-core sandbox, with tests. Add a few FIXMEs to broken relation removal tests in PyJuju sandbox, to be fixed later. https://code.launchpad.net/~teknico/juju-gui/add-remove-rels-go-sandbox/+merge/171514 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add/remove relations in juju-core sandbox. #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -3 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/python.js	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	app/store/env/sandbox.js	View		1 chunk	+66 lines, -0 lines	0 comments	Download
M	test/index.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/test_sandbox.js	View		7 chunks	+173 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

LGTM. Very nice. Thanks, and thanks for observing and noting the issues on the Python ...

12 years ago (2013-06-26 12:10:35 UTC) #2

teknico

12 years ago (2013-06-26 16:42:55 UTC) #4

*** Submitted:

Add/remove relations in juju-core sandbox.

Implement add/remove relations in juju-core sandbox, with tests.

Add a few FIXMEs to broken relation removal tests in PyJuju sandbox,
to be fixed later.

R=gary.poster, frankban
CC=
https://codereview.appspot.com/10605043

Expand All Messages | Collapse All Messages