Issue 105800043: code review 105800043: build: rename " and "" to quote1 and quote2 for hg

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105800043: code review 105800043: build: rename " and "" to quote1 and quote2 for hg (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rsc

Modified:
10 years, 7 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

build: rename " and "" to quote1 and quote2 for hg They'll be copied back during installation but then hg doesn't have to create those files on systems that have trouble with them.

Patch Set 1 #

Patch Set 2 : diff -r a36fd96451f6 https://code.google.com/p/plan9port #

Patch Set 3 : diff -r a36fd96451f6 https://code.google.com/p/plan9port #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, --2 lines)			Patch
M	INSTALL	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	bin/quote1	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	bin/quote2	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port

10 years, 7 months ago (2014-06-03 18:29:00 UTC) #1

rsc

10 years, 7 months ago (2014-06-03 18:29:04 UTC) #2

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=cf8059f811e1 ***

build: rename " and "" to quote1 and quote2 for hg

They'll be copied back during installation
but then hg doesn't have to create those files
on systems that have trouble with them.

TBR=rsc
https://codereview.appspot.com/105800043

Expand All Messages | Collapse All Messages