Issue 10574043: Changing auth to use Google+ sign-in.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10574043: Changing auth to use Google+ sign-in. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by dhermes

Modified:
10 years, 10 months ago

Reviewers:
danielholevoet

Visibility:
Public.

More Reviews

Patch Set 2 : Updating CSS. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -67 lines)			Patch
A	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	static/css/base.css	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	static/js/base.js	View		4 chunks	+17 lines, -58 lines	0 comments	Download
A	static/js/render.js	View		1 chunk	+95 lines, -0 lines	0 comments	Download
M	templates/tictactoe.html	View		2 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

danielholevoet

https://codereview.appspot.com/10574043/diff/1/static/css/base.css File static/css/base.css (right): https://codereview.appspot.com/10574043/diff/1/static/css/base.css#newcode70 static/css/base.css:70: display: block; Should this be display: box? https://codereview.appspot.com/10574043/diff/1/static/css/base.css#newcode71 static/css/base.css:71: ...

10 years, 10 months ago (2013-06-25 23:17:37 UTC) #2

danielholevoet

On 2013/06/25 23:24:03, dhermes wrote: > Updating CSS. LGTM

10 years, 10 months ago (2013-06-25 23:24:21 UTC) #4

dhermes

10 years, 10 months ago (2013-06-25 23:24:35 UTC) #5

Added in
https://github.com/GoogleCloudPlatform/appengine-endpoints-tictactoe-python/c...

Expand All Messages | Collapse All Messages