Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1223)

Issue 105720043: Refactor to callback services API

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by johnsca
Modified:
9 years, 11 months ago
Reviewers:
benjamin.saller, mp+221446
Visibility:
Public.

Description

Refactor to callback services API https://code.launchpad.net/~johnsca/charms/trusty/cf-nats/services-callback-fu/+merge/221446 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Refactor to callback services API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -317 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/charmhelpers/contrib/cloudfoundry/contexts.py View 1 chunk +41 lines, -32 lines 0 comments Download
M hooks/charmhelpers/core/host.py View 1 chunk +5 lines, -0 lines 0 comments Download
M hooks/charmhelpers/core/services.py View 1 chunk +316 lines, -79 lines 0 comments Download
M hooks/charmhelpers/core/templating.py View 2 chunks +45 lines, -146 lines 0 comments Download
M hooks/config.py View 2 chunks +25 lines, -0 lines 0 comments Download
D hooks/hooks.py View 3 chunks +13 lines, -60 lines 0 comments Download

Messages

Total messages: 3
johnsca
Please take a look.
9 years, 11 months ago (2014-05-29 18:31:54 UTC) #1
benjamin.saller
LGTM, thanks
9 years, 11 months ago (2014-05-29 18:46:06 UTC) #2
johnsca
9 years, 11 months ago (2014-05-29 20:28:41 UTC) #3
*** Submitted:

Refactor to callback services API

R=benjamin.saller
CC=
https://codereview.appspot.com/105720043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b