Issue 10556044: Clean up license headers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10556044: Clean up license headers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by jcgregorio_google

Modified:
13 years ago

Reviewers:
dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 1

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -2 lines)			Patch
M	apiclient/__init__.py	View	1 chunk	+14 lines, -0 lines	1 comment	Download
M	oauth2client/locked_file.py	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	oauth2client/multistore_file.py	View	1 chunk	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dhermes

LGTM https://codereview.appspot.com/10556044/diff/1/apiclient/__init__.py File apiclient/__init__.py (right): https://codereview.appspot.com/10556044/diff/1/apiclient/__init__.py#newcode1 apiclient/__init__.py:1: # Copyright (C) 2012 Google Inc. It's 2013 ...

13 years ago (2013-06-25 19:11:15 UTC) #2

jcgregorio_google

On 2013/06/25 19:11:15, dhermes wrote: > LGTM > > https://codereview.appspot.com/10556044/diff/1/apiclient/__init__.py > File apiclient/__init__.py (right): > ...

13 years ago (2013-06-25 19:19:12 UTC) #3

jcgregorio_google

On 2013/06/25 19:19:12, jcgregorio_google wrote: > On 2013/06/25 19:11:15, dhermes wrote: > > LGTM > ...

13 years ago (2013-06-25 19:19:28 UTC) #4

dhermes

13 years ago (2013-06-25 19:20:14 UTC) #5

On 2013/06/25 19:19:12, jcgregorio_google wrote:
> On 2013/06/25 19:11:15, dhermes wrote:
> > LGTM
> > 
> > https://codereview.appspot.com/10556044/diff/1/apiclient/__init__.py
> > File apiclient/__init__.py (right):
> > 
> >
https://codereview.appspot.com/10556044/diff/1/apiclient/__init__.py#newcode1
> > apiclient/__init__.py:1: # Copyright (C) 2012 Google Inc.
> > It's 2013 FWIW. 
> 
> 
> D'oh.
> 
> > Also, these aren't necessary if the project has a LICENSE in it.
> 
> I know they aren't, but I got a request for this change because the 
> headers in their former state was triggering the license scanner
> for Chromium tools.

SGTM.

Insert Khaaaaan meme with Chrome

Expand All Messages | Collapse All Messages