Issue 10554044: Add support for related charms on interfaces tab.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rharding

Modified:
11 years, 9 months ago

Reviewers:
jeff.pihach, matthew.scott, mp+171136

Visibility:
Public.

Description

Add support for related charms on interfaces tab. - Update the charm-token for a 'tiny' size. - Render tiny charm-tokens for 3 related charms per interface listed - Update the related.json to actually be related to the charm data for apache. - Update model tests. - Add smaller 48px images for categories/default charm icon support in the tokens. https://code.launchpad.net/~rharding/juju-gui/interface-tab-related/+merge/171136 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add support for related charms on interfaces tab. #

Total comments: 3

Patch Set 3 : Add support for related charms on interfaces tab. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1927 lines, -532 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/images/charm-app-servers-48.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/charm-applications-48.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/charm-cache-proxy-48.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/charm-database-48.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/charm-file-server-48.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/charm-misc-48.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/charm_48.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	app/assets/images/non-sprites/charm_160.svg	View	1	1 chunk	+271 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View		1 chunk	+35 lines, -16 lines	0 comments	Download
M	app/subapps/browser/views/charm.js	View	1 2	5 chunks	+70 lines, -11 lines	0 comments	Download
M	app/templates/charm-token.handlebars	View		1 chunk	+11 lines, -1 line	0 comments	Download
M	lib/views/browser/charm-token.less	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	test/data/related.json	View		37 chunks	+1400 lines, -506 lines	0 comments	Download
M	test/test_browser_charm_details.js	View	1 2	4 chunks	+89 lines, -3 lines	0 comments	Download
M	test/test_charm_token.js	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	test/test_model.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM - all trivial comments, change if you want. Looks like you reversed some of ...

11 years, 9 months ago (2013-06-25 17:10:29 UTC) #4

rharding

11 years, 9 months ago (2013-06-25 17:44:34 UTC) #5

*** Submitted:

Add support for related charms on interfaces tab.

- Update the charm-token for a 'tiny' size.
- Render tiny charm-tokens for 3 related charms per interface listed
- Update the related.json to actually be related to the charm data for apache.
- Update model tests. 
- Add smaller 48px images for categories/default charm icon support in the
tokens.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/10554044

Expand All Messages | Collapse All Messages