Issue 105530043: code review 105530043: encoding/gob: fewer decAlloc calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105530043: code review 105530043: encoding/gob: fewer decAlloc calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by rsc

Modified:
10 years, 11 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

encoding/gob: fewer decAlloc calls Move decAlloc calls a bit higher in the call tree. Cleans code marginally, improves speed marginally. The benchmarks are noisy but the median time from 20 consective 1-second runs improves by about 2%.

Patch Set 1 #

Patch Set 2 : diff -r 04a5bbd18c65 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 04a5bbd18c65 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3e041f7ef9ff https://code.google.com/p/go/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -28 lines)			Patch
	M	src/pkg/encoding/gob/codec_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/encoding/gob/decode.go	View	1 2 3	23 chunks	+36 lines, -27 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 11 months ago (2014-07-01 14:59:57 UTC) #1

rsc

10 years, 11 months ago (2014-07-01 18:19:30 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=bc2977cf4e3b ***

encoding/gob: fewer decAlloc calls

Move decAlloc calls a bit higher in the call tree.
Cleans code marginally, improves speed marginally.
The benchmarks are noisy but the median time from
20 consective 1-second runs improves by about 2%.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/105530043

Expand All Messages | Collapse All Messages