Issue 10550043: resumer: fix test race

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10550043: resumer: fix test race (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by mue

Modified:
10 years, 10 months ago

Reviewers:
dimitern, mp+171342, fwereade

Visibility:
Public.

Description

resumer: fix test race The resumer test might lead to a race (detected by Roger). So changed it to taking and comparing timestamps for each call of the resumer mock. https://code.launchpad.net/~themue/juju-core/031-fix-resumer-test/+merge/171342 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -7 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	worker/resumer/resumer_test.go	View		1 chunk	+15 lines, -7 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

LGTM modulo a single suggestion. https://codereview.appspot.com/10550043/diff/1/worker/resumer/resumer_test.go File worker/resumer/resumer_test.go (right): https://codereview.appspot.com/10550043/diff/1/worker/resumer/resumer_test.go#newcode47 worker/resumer/resumer_test.go:47: c.Assert(len(tr.timestamps) > 0, Equals, ...

10 years, 10 months ago (2013-06-27 14:33:25 UTC) #3

mue

10 years, 10 months ago (2013-06-27 18:03:31 UTC) #4

https://codereview.appspot.com/10550043/diff/1/worker/resumer/resumer_test.go
File worker/resumer/resumer_test.go (right):

https://codereview.appspot.com/10550043/diff/1/worker/resumer/resumer_test.go...
worker/resumer/resumer_test.go:47: c.Assert(len(tr.timestamps) > 0, Equals,
true)
On 2013/06/27 14:33:26, dimitern wrote:
> This code block is a bit obscure to my puny mind - can you put some comment
> describing what we're actually doing here please?

Done.

Expand All Messages | Collapse All Messages