Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(942)

Issue 105470043: code review 105470043: misc: delete editor and shell support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by r
Modified:
10 years, 4 months ago
Reviewers:
ruiu, gobot, kisielk, josharian, dave, rsc, rminnich1, gri
CC:
golang-codereviews, rminnich1, kisielk, gri, rsc, Dominik Honnef, dave_cheney.net, josharian, ruiu, ajstarks
Visibility:
Public.

Description

misc: delete editor and shell support We are not the right people to support editor plugins, and the profusion of editors in this CL demonstrates the unreality of pretending to do so. People are free to create and advertise their own repos with support. For discussion: https://groups.google.com/forum/#!topic/golang-dev/SA7fD470FxU

Patch Set 1 #

Patch Set 2 : diff -r c31a70f2f542 https://code.google.com/p/go #

Patch Set 3 : diff -r 04a5bbd18c65 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4335 lines) Patch
R misc/IntelliJIDEA/Go.xml View 1 chunk +0 lines, -99 lines 0 comments Download
R misc/bash/go View 1 chunk +0 lines, -237 lines 0 comments Download
R misc/bbedit/Go.plist View 1 chunk +0 lines, -104 lines 0 comments Download
A misc/editors View 1 1 chunk +5 lines, -0 lines 0 comments Download
R misc/emacs/go-mode.el View 1 chunk +0 lines, -1234 lines 0 comments Download
R misc/emacs/go-mode-load.el View 1 chunk +0 lines, -96 lines 0 comments Download
R misc/fraise/go.plist View 1 chunk +0 lines, -92 lines 0 comments Download
R misc/fraise/readme.txt View 1 chunk +0 lines, -16 lines 0 comments Download
R misc/kate/go.xml View 1 chunk +0 lines, -150 lines 0 comments Download
R misc/notepadplus/README View 1 chunk +0 lines, -59 lines 0 comments Download
R misc/notepadplus/functionList.xml View 1 chunk +0 lines, -50 lines 0 comments Download
R misc/notepadplus/go.xml View 1 chunk +0 lines, -133 lines 0 comments Download
R misc/notepadplus/userDefineLang.xml View 1 chunk +0 lines, -64 lines 0 comments Download
R misc/vim/autoload/go/complete.vim View 1 chunk +0 lines, -103 lines 0 comments Download
R misc/vim/compiler/go.vim View 1 chunk +0 lines, -30 lines 0 comments Download
R misc/vim/ftdetect/gofiletype.vim View 1 chunk +0 lines, -23 lines 0 comments Download
R misc/vim/ftplugin/go.vim View 1 chunk +0 lines, -19 lines 0 comments Download
R misc/vim/ftplugin/go/fmt.vim View 1 chunk +0 lines, -69 lines 0 comments Download
R misc/vim/ftplugin/go/import.vim View 1 chunk +0 lines, -250 lines 0 comments Download
R misc/vim/ftplugin/go/test.sh View 1 chunk +0 lines, -78 lines 0 comments Download
R misc/vim/indent/go.vim View 1 chunk +0 lines, -77 lines 0 comments Download
R misc/vim/plugin/godoc.vim View 1 chunk +0 lines, -130 lines 0 comments Download
R misc/vim/readme.txt View 1 chunk +0 lines, -103 lines 0 comments Download
R misc/vim/syntax/go.vim View 1 chunk +0 lines, -207 lines 0 comments Download
R misc/vim/syntax/godoc.vim View 1 chunk +0 lines, -20 lines 0 comments Download
R misc/xcode/3/README View 1 chunk +0 lines, -3 lines 0 comments Download
R misc/xcode/3/go.pbfilespec View 1 chunk +0 lines, -31 lines 0 comments Download
R misc/xcode/3/go.xclangspec View 1 chunk +0 lines, -293 lines 0 comments Download
R misc/xcode/4/README View 1 chunk +0 lines, -2 lines 0 comments Download
R misc/xcode/4/go.xclangspec View 1 chunk +0 lines, -290 lines 0 comments Download
R misc/xcode/4/go4xcode.sh View 1 chunk +0 lines, -112 lines 0 comments Download
R misc/zsh/go View 1 chunk +0 lines, -161 lines 0 comments Download

Messages

Total messages: 17
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2014-06-27 22:40:17 UTC) #1
rminnich1
LGTM
10 years, 4 months ago (2014-06-27 22:42:51 UTC) #2
kisielk
LGTM. For vim I think many people just use https://github.com/fatih/vim-go or https://github.com/jnwhiteh/vim-golang (a mirror of ...
10 years, 4 months ago (2014-06-27 23:26:12 UTC) #3
gri
LGTM
10 years, 4 months ago (2014-06-27 23:30:42 UTC) #4
rsc
LGTM
10 years, 4 months ago (2014-06-27 23:39:50 UTC) #5
Dominik Honnef
FTR, the canonical misc/emacs repository will be https://github.com/dominikh/go-mode.el (For people finding this CL while wondering ...
10 years, 4 months ago (2014-06-27 23:55:25 UTC) #6
dave_cheney.net
LGTM. Please remember to add a note to 1.4.txt.
10 years, 4 months ago (2014-06-27 23:56:59 UTC) #7
josharian
LGTM Is it worth leaving any breadcrumbs? We'll also want to update http://godoc.org/code.google.com/p/go.tools/cmd/goimports, and search ...
10 years, 4 months ago (2014-06-28 18:31:09 UTC) #8
r
Hello golang-codereviews@googlegroups.com, rminnich@google.com, kamil.kisiel@gmail.com, gri@golang.org, rsc@golang.org, dominik.honnef@gmail.com, dave@cheney.net, josharian@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 4 months ago (2014-06-30 23:05:05 UTC) #9
r
Added a misc/editors file to redirect people to the wiki, where the information about the ...
10 years, 4 months ago (2014-06-30 23:06:04 UTC) #10
rminnich1
LGTM
10 years, 4 months ago (2014-06-30 23:09:37 UTC) #11
ruiu
LGTM. Where is the new home of bash and other shell support files? Who's the ...
10 years, 4 months ago (2014-06-30 23:50:14 UTC) #12
r
The new home is wherever people responsible want to make be home. It's up to ...
10 years, 4 months ago (2014-07-01 00:03:13 UTC) #13
josharian
LGTM
10 years, 4 months ago (2014-07-01 01:10:31 UTC) #14
ajstarks
On 2014/06/30 23:06:04, r wrote: > Added a misc/editors file to redirect people to the ...
10 years, 4 months ago (2014-07-01 04:32:34 UTC) #15
r
*** Submitted as https://code.google.com/p/go/source/detail?r=d35d2b112a56 *** misc: delete editor and shell support We are not the ...
10 years, 4 months ago (2014-07-01 16:21:31 UTC) #16
gobot
10 years, 4 months ago (2014-07-03 06:25:23 UTC) #17
Message was sent while issue was closed.
This CL appears to have broken the linux-386 builder.
See http://build.golang.org/log/997e07a75a4e231642f464024189da47dad91f4f
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b