Issue 10543044: Updates to NR chapter 2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10543044: Updates to NR chapter 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by PhilEHolmes

Modified:
10 years, 10 months ago

Reviewers:
Graham Percival, thomasmorley651, Jean-Charles, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

2nd tranche of proposed changes to the NR.

Patch Set 1 #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -33 lines)			Patch
M	Documentation/notation/ancient.itely	View	1 chunk	+11 lines, -10 lines	0 comments	Download
M	Documentation/notation/chords.itely	View	1 chunk	+10 lines, -11 lines	1 comment	Download
M	Documentation/notation/fretted-strings.itely	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/notation/vocal.itely	View	4 chunks	+15 lines, -10 lines	1 comment	Download
M	Documentation/notation/wind.itely	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Jean-Charles

fro the rest, LGTM https://codereview.appspot.com/10543044/diff/1/Documentation/notation/chords.itely File Documentation/notation/chords.itely (right): https://codereview.appspot.com/10543044/diff/1/Documentation/notation/chords.itely#newcode442 Documentation/notation/chords.itely:442: chordmusic = \relative c'{ space ...

10 years, 10 months ago (2013-06-25 16:53:46 UTC) #2

thomasmorley651

One nitpick. Otherwise LGTM https://codereview.appspot.com/10543044/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/10543044/diff/1/Documentation/notation/vocal.itely#newcode629 Documentation/notation/vocal.itely:629: sung on one syllable; this ...

10 years, 10 months ago (2013-06-25 18:31:47 UTC) #3

LGTM

Expand All Messages | Collapse All Messages