Issue 105370044: code review 105370044: go.exp/fsnotify: a new API (Closed)
Descriptiongo.exp/fsnotify: a new API
* Rename Watch(path string) to Add(name string).
* Rename RemoveWatch(path string) to Remove(name string).
* Pluralized channel names: Events and Errors.
* Renamed FileEvent struct to Event.
* Events channel of type Event rather than *FileEvent.
* Op constants replace methods like IsCreate().
* Remove AddWatch on Windows, use Add.
Minor internal cleanup:
* remove internal watch and removeWatch methods.
* Windows uses syscall.ERROR_MORE_DATA internally (requires Go 1.3+).
* use syscall constants directly for inotify and kqueue.
* remove cookie from Event struct (presently unused).
* Event struct now has the same definition across every OS.
* kqueue: rename events to kevents and fileEvent to event.
Patch Set 1 #Patch Set 2 : diff -r 93897be904a1 https://code.google.com/p/go.exp #Patch Set 3 : diff -r 93897be904a1 https://code.google.com/p/go.exp #Patch Set 4 : diff -r 93897be904a1 https://code.google.com/p/go.exp #
MessagesTotal messages: 7
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
