Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5356)

Issue 105370043: Doc: NR Section 4.3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by pkx166h
Modified:
7 years, 1 month ago
Reviewers:
Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR Section 4.3 Start of issue 3960 The whole section doesn't follow many aspects of Documentation policy. So the first stage of this issue tracker is to tidy up the section before then making changes to technical information. Line breaks as per the CG Added some @seealsos Basic LilyPond doc formatting considerations, although this is not complete, there would be too much to do for a single patch, so I expect to have to make a few more patches to tidy this section up completely. A few of these sections seem to 'talk through the code' so may need to be improved later on. However, for now I have moved these subsections to unnumberedsubsubsec under the main 'Page Breaking' node. Moved one of these new unnumberedsubsucsecs around so that the sections on the different breaks come before the turning one. One subsection was basically a snippet for page handling line breaking using multiple voices and really needed to be turned into a snippet, so I have done this.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Trevor's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -221 lines) Patch
M Documentation/notation/spacing.itely View 1 13 chunks +152 lines, -220 lines 0 comments Download
M Documentation/notation/vocal.itely View 1 chunk +1 line, -1 line 0 comments Download
A Documentation/snippets/new/using-an-extra-voice-for-breaks.ly View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Trevor Daniels
Thanks, James. Just 1 minor nitpick, otherwise LGTM Trevor https://codereview.appspot.com/105370043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/105370043/diff/1/Documentation/notation/spacing.itely#newcode1714 Documentation/notation/spacing.itely:1714: ...
9 years, 10 months ago (2014-06-22 16:27:50 UTC) #1
pkx166h
Trevor's suggestion
9 years, 10 months ago (2014-06-22 17:54:30 UTC) #2
pkx166h
Thanks Trevor. https://codereview.appspot.com/105370043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/105370043/diff/1/Documentation/notation/spacing.itely#newcode1714 Documentation/notation/spacing.itely:1714: property @code{minimumRepeatLengthForPageTurn} where the On 2014/06/22 16:27:50, ...
9 years, 10 months ago (2014-06-22 17:55:03 UTC) #3
pkx166h
7 years, 1 month ago (2017-03-19 13:20:06 UTC) #4
author    James Lowe <pkx166h@gmail.com>   
    Sat, 21 Jun 2014 20:28:55 +0000 (21:28 +0100)
committer    James Lowe <pkx166h@gmail.com>   
    Sun, 29 Jun 2014 08:09:18 +0000 (09:09 +0100)
commit    [raec840a735b33a4be38b10baeb40f8e660e3d55c]
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b