code review 105280045: runtime: disable funky wide string test for now.

runtime: disable funky wide string test for now.

[khr, 2014-06-17 07:44:47]

Hello bradfitz (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[khr, 2014-06-17 07:45:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=c5bf1d4dae6a ***

runtime: disable funky wide string test for now.

TBR=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/105280045

[brainman, 2014-06-17 07:49:29]

I'm happy to run tests any time you need to. Just CC me.

Alex

[khr1, 2014-06-17 07:52:14]

This test passed when I ran it with "go test runtime -test.run=StringW
-test.v" but that same test doesn't pass when invoked by all.bash.
I don't understand why that is.
Nor do I understand why the test fails.  Disabled for now, figure it out in
the morning.



On Tue, Jun 17, 2014 at 12:45 AM, <khr@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=c5bf1d4dae6a ***
>
>
> runtime: disable funky wide string test for now.
>
> TBR=bradfitz
> R=bradfitz
> CC=golang-codereviews
> https://codereview.appspot.com/105280045
>
>
> https://codereview.appspot.com/105280045/
>

[r, 2014-06-17 14:12:46]

https://codereview.appspot.com/105280045/diff/80001/src/pkg/runtime/string_te...
File src/pkg/runtime/string_test.go (right):

https://codereview.appspot.com/105280045/diff/80001/src/pkg/runtime/string_te...
src/pkg/runtime/string_test.go:107: //"a\u5566\u7788b",
you should put in a comment saying why this is done.

[khr1, 2014-06-17 15:14:37]

Figured it all out.  Forgot null termination.  CL to reenable out for
review.


On Tue, Jun 17, 2014 at 7:12 AM, <r@golang.org> wrote:

>
> https://codereview.appspot.com/105280045/diff/80001/src/
> pkg/runtime/string_test.go
> File src/pkg/runtime/string_test.go (right):
>
> https://codereview.appspot.com/105280045/diff/80001/src/
> pkg/runtime/string_test.go#newcode107
> src/pkg/runtime/string_test.go:107: //"a\u5566\u7788b",
> you should put in a comment saying why this is done.
>
> https://codereview.appspot.com/105280045/
>