Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(190)

Issue 105180043: Fix unmarshalling of nil strings

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by wallyworld
Modified:
5 years, 11 months ago
Reviewers:
mp+223017, axw
Visibility:
Public.

Description

Fix unmarshalling of nil strings In some nova structs sent and received over the wire, serialised as json, there are id attributes which can be string or int. We have custom marshalling to handle that, but where the attributes were string pointers, we were always unmarshalling as "" if the value was nil. This broke things like floating ip address usage. https://code.launchpad.net/~wallyworld/goose/fix-nil-string-unmarshalling/+merge/223017 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -32 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M nova/json.go View 3 chunks +31 lines, -17 lines 0 comments Download
M nova/json_test.go View 2 chunks +38 lines, -15 lines 0 comments Download

Messages

Total messages: 2
wallyworld
Please take a look.
5 years, 11 months ago (2014-06-13 06:43:18 UTC) #1
axw
5 years, 11 months ago (2014-06-13 06:49:26 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b