code review 105160043: go.tools/go/types, exact: fix build for 1.2

go.tools/go/types, exact: fix build for 1.2

Fixes issue 8192.

[gri, 2014-06-12 19:35:13]

Hello bradfitz@golang.org, adonovan@google.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2014-06-12 19:38:35]

https://codereview.appspot.com/105160043/diff/40001/go/exact/go13.go
File go/exact/go13.go (right):

https://codereview.appspot.com/105160043/diff/40001/go/exact/go13.go#newcode17
go/exact/go13.go:17: // imprecission in corner cases.
typo: imprecision

https://codereview.appspot.com/105160043/diff/40001/go/exact/go14.go
File go/exact/go14.go (right):

https://codereview.appspot.com/105160043/diff/40001/go/exact/go14.go#newcode5
go/exact/go14.go:5: // +build go1.4
this typically won't work until late in the Go 1.4 release cycle.  if this is
important sooner, we'll need to add the go1.4 tag earlier in the dev cycle.

https://codereview.appspot.com/105160043/diff/40001/go/types/stdlib_test.go
File go/types/stdlib_test.go (right):

https://codereview.appspot.com/105160043/diff/40001/go/types/stdlib_test.go#n...
go/types/stdlib_test.go:122: "float_lit2.go",  // TODO(gri) enable for releases
1.4 and higher
could add an init() updating a global bool to those existing +build files and
this test here could conditionally test this file.

[gri, 2014-06-12 19:41:00]

PTAL

https://codereview.appspot.com/105160043/diff/40001/go/exact/go13.go
File go/exact/go13.go (right):

https://codereview.appspot.com/105160043/diff/40001/go/exact/go13.go#newcode17
go/exact/go13.go:17: // imprecission in corner cases.
On 2014/06/12 19:38:34, bradfitz wrote:
> typo: imprecision

Done.

https://codereview.appspot.com/105160043/diff/40001/go/exact/go14.go
File go/exact/go14.go (right):

https://codereview.appspot.com/105160043/diff/40001/go/exact/go14.go#newcode5
go/exact/go14.go:5: // +build go1.4
On 2014/06/12 19:38:34, bradfitz wrote:
> this typically won't work until late in the Go 1.4 release cycle.  if this is
> important sooner, we'll need to add the go1.4 tag earlier in the dev cycle.

It's fine for now, the tests are disabled.

https://codereview.appspot.com/105160043/diff/40001/go/types/stdlib_test.go
File go/types/stdlib_test.go (right):

https://codereview.appspot.com/105160043/diff/40001/go/types/stdlib_test.go#n...
go/types/stdlib_test.go:122: "float_lit2.go",  // TODO(gri) enable for releases
1.4 and higher
On 2014/06/12 19:38:34, bradfitz wrote:
> could add an init() updating a global bool to those existing +build files and
> this test here could conditionally test this file.

something like that - not urgent

[bradfitz, 2014-06-12 19:44:53]

LGTM

[gri, 2014-06-12 19:46:24]

*** Submitted as
https://code.google.com/p/go/source/detail?r=6ce613415caa&repo=tools ***

go.tools/go/types, exact: fix build for 1.2

Fixes issue 8192.

LGTM=bradfitz
R=bradfitz, adonovan
CC=golang-codereviews
https://codereview.appspot.com/105160043