Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(831)

Issue 10500044: Make charms able to be dragged to the environment.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by benji
Modified:
6 years, 9 months ago
Reviewers:
rharding, mp+171084
Visibility:
Public.

Description

Make charms able to be dragged to the environment. https://code.launchpad.net/~benji/juju-gui/charm-dnd-2/+merge/171084 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make charms able to be dragged to the environment. #

Total comments: 42

Patch Set 3 : Make charms able to be dragged to the environment. #

Total comments: 16

Patch Set 4 : Make charms able to be dragged to the environment. #

Patch Set 5 : Make charms able to be dragged to the environment. #

Patch Set 6 : Make charms able to be dragged to the environment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -41 lines) Patch
A [revision details] View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 1 2 3 4 5 21 chunks +32 lines, -25 lines 0 comments Download
M app/subapps/browser/views/editorial.js View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M app/views/charm-panel.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M app/views/topology/importexport.js View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
M app/views/topology/service.js View 1 2 3 4 2 chunks +21 lines, -1 line 0 comments Download
M app/widgets/charm-token.js View 1 2 3 3 chunks +82 lines, -3 lines 0 comments Download
M test/index.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A test/test_charm_token_drag_and_drop.js View 1 2 3 1 chunk +147 lines, -0 lines 0 comments Download
M test/test_notifier_widget.js View 1 2 1 chunk +9 lines, -9 lines 0 comments Download
M test/test_service_module.js View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11
benji
Please take a look.
6 years, 9 months ago (2013-06-24 13:45:57 UTC) #1
benji
On 2013/06/24 13:45:57, benji wrote: > Please take a look. But only once I have ...
6 years, 9 months ago (2013-06-24 13:50:12 UTC) #2
benji
Please take a look.
6 years, 9 months ago (2013-06-24 21:36:13 UTC) #3
jeff.pihach
This is such a cool feature thanks for implementing it. I added a comment about ...
6 years, 9 months ago (2013-06-24 22:35:08 UTC) #4
rharding
Comments below. Jeff has some great feedback and I agree that there's some work around ...
6 years, 9 months ago (2013-06-25 11:36:52 UTC) #5
benji
Please take a look. https://codereview.appspot.com/10500044/diff/5001/app/app.js File app/app.js (right): https://codereview.appspot.com/10500044/diff/5001/app/app.js#newcode582 app/app.js:582: Y.on('initiateDeploy', function(charm) { On 2013/06/24 ...
6 years, 9 months ago (2013-06-25 20:56:35 UTC) #6
rharding
LGTM with the discussion on using boundingBox via cfg vs the container and the simpler ...
6 years, 9 months ago (2013-06-25 21:15:09 UTC) #7
benjamin.saller
Thanks for this, going to be a really nice feature when it lands. I think ...
6 years, 9 months ago (2013-06-25 21:29:18 UTC) #8
benji
Thanks guys. I think I have responded to all the feedback. I need to merge ...
6 years, 9 months ago (2013-06-26 13:43:53 UTC) #9
benji
Please take a look.
6 years, 9 months ago (2013-06-26 13:52:49 UTC) #10
benji
6 years, 9 months ago (2013-06-26 14:27:35 UTC) #11
*** Submitted:

Make charms able to be dragged to the environment.

R=jeff.pihach, rharding, benjamin.saller
CC=
https://codereview.appspot.com/10500044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b