Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(146)

Issue 10495046: Inspector prep

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by matthew.scott
Modified:
12 years, 8 months ago
Reviewers:
frankban, jeff.pihach, mp+171170
Visibility:
Public.

Description

Inspector prep A bit of prep work to start getting the inspector more closely aligned with the wireframes. This moves some of the tabs up, adds future options for destroying/exposing, adds a service health indicator (currently always divided into even thirds; per Jeff, the ability to make the calculations to easily set these sizes dynamically may be coming in the future), and starts partitioning the panel for unit counts and unit display. This was intended to be a limited scope branch so that we can start swarming later in the week, so it's mostly cosmetic. https://code.launchpad.net/~makyo/juju-gui/partials/+merge/171170 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Inspector prep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -18 lines) Patch
[revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
app/app.js View 1 1 chunk +1 line, -1 line 0 comments Download
app/templates/serviceOverview.handlebars View 1 chunk +21 lines, -12 lines 0 comments Download
app/templates/view-container.handlebars View 1 chunk +13 lines, -4 lines 0 comments Download
lib/views/juju-inspector.less View 1 chunk +45 lines, -1 line 0 comments Download

Messages

Total messages: 5
matthew.scott
Please take a look.
12 years, 8 months ago (2013-06-24 21:08:27 UTC) #1
jeff.pihach
LGTM with one q below https://codereview.appspot.com/10495046/diff/1/app/templates/view-container.handlebars File app/templates/view-container.handlebars (left): https://codereview.appspot.com/10495046/diff/1/app/templates/view-container.handlebars#oldcode9 app/templates/view-container.handlebars:9: <div class="tab" data-viewlet="config" Why ...
12 years, 8 months ago (2013-06-24 21:24:10 UTC) #2
matthew.scott
https://codereview.appspot.com/10495046/diff/1/app/templates/view-container.handlebars File app/templates/view-container.handlebars (left): https://codereview.appspot.com/10495046/diff/1/app/templates/view-container.handlebars#oldcode9 app/templates/view-container.handlebars:9: <div class="tab" data-viewlet="config" On 2013/06/24 21:24:10, jeff.pihach wrote: > ...
12 years, 8 months ago (2013-06-24 21:26:06 UTC) #3
frankban
LGTM, thank you!
12 years, 8 months ago (2013-06-25 10:06:13 UTC) #4
matthew.scott
12 years, 8 months ago (2013-06-25 14:40:30 UTC) #5
*** Submitted:

Inspector prep

A bit of prep work to start getting the inspector more closely aligned with the
wireframes.  This moves some of the tabs up, adds future options for
destroying/exposing, adds a service health indicator (currently always divided
into even thirds; per Jeff, the ability to make the calculations to easily set
these sizes dynamically may be coming in the future), and starts partitioning
the panel for unit counts and unit display.  This was intended to be a limited
scope branch so that we can start swarming later in the week, so it's mostly
cosmetic.

R=jeff.pihach, frankban
CC=
https://codereview.appspot.com/10495046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b