Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 104950045: code review 104950045: cmd/ld: fix PC deltas in DWARF line number table (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by iant
Modified:
5 years, 5 months ago
Reviewers:
gobot, rsc, dfc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/ld: fix PC deltas in DWARF line number table The putpclcdelta function set the DWARF line number PC to s->value + pcline->pc, which is correct, but the code then set the local variable pc to epc, which can be a different value. This caused the next delta in the DWARF table to be wrong. Fixes issue 8098.

Patch Set 1 #

Patch Set 2 : diff -r 087e446f2c41 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/ld/dwarf.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
iant
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
5 years, 5 months ago (2014-06-10 21:03:17 UTC) #1
rsc
LGTM
5 years, 5 months ago (2014-06-10 21:03:48 UTC) #2
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=87daa424d96a *** cmd/ld: fix PC deltas in DWARF line number table The ...
5 years, 5 months ago (2014-06-10 21:11:42 UTC) #3
gobot
This CL appears to have broken the darwin-386-cheney builder. See http://build.golang.org/log/b9b18af993d72cafdf7ecd0408f6c8d96773b161
5 years, 5 months ago (2014-06-11 02:31:55 UTC) #4
dfc
5 years, 5 months ago (2014-06-11 02:33:30 UTC) #5
Ignore. rsc has submitted a fix for the spurious timeout errors.


On Wed, Jun 11, 2014 at 12:31 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the darwin-386-cheney builder.
> See http://build.golang.org/log/b9b18af993d72cafdf7ecd0408f6c8d96773b161
>
>
> https://codereview.appspot.com/104950045/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b