Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(108)

Issue 104940045: Error if local env requested but not supported.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by bac
Modified:
9 years, 11 months ago
Reviewers:
mp+222562
Visibility:
Public.

Description

Error if local env requested but not supported. If '-e some-local-environment' is used on a host that does not support LXC, then bootstrap will be called and an obscure 'apt-config' error is thrown. So, let's not do that. Instead, detect the error early and return an argparse error that makes sense. https://code.launchpad.net/~bac/juju-quickstart/local-error-osx/+merge/222562 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Error if local env requested but not supported. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/manage.py View 1 chunk +7 lines, -1 line 0 comments Download
M quickstart/tests/test_manage.py View 3 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 3
bac
Please take a look.
9 years, 11 months ago (2014-06-09 21:07:38 UTC) #1
bac
LGTM self-review.
9 years, 11 months ago (2014-06-09 21:14:36 UTC) #2
bac
9 years, 11 months ago (2014-06-09 21:16:46 UTC) #3
*** Submitted:

Error if local env requested but not supported.

If '-e some-local-environment' is used on a host that does not support LXC,
then bootstrap will be called and an obscure 'apt-config' error is thrown.
So, let's not do that.  Instead, detect the error early and return an argparse
error that makes sense.

R=
CC=
https://codereview.appspot.com/104940045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b