Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197)

Issue 10484043: code review 10484043: go.talks/present: log websocket close message to consol... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by adg
Modified:
7 years, 7 months ago
Reviewers:
CC:
golang-dev
Visibility:
Public.

Description

go.talks/present: log websocket close message to console, not popup On platforms that don't support websockets, this makes the whole experience a lot less obnoxious.

Patch Set 1 #

Patch Set 2 : diff -r b99d8b2510ba https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M present/js/socket.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
7 years, 7 months ago (2013-06-24 03:56:30 UTC) #1
adg
7 years, 7 months ago (2013-06-25 10:29:48 UTC) #2
*** Submitted as
https://code.google.com/p/go/source/detail?r=27c84def09a6&repo=talks ***

go.talks/present: log websocket close message to console, not popup

On platforms that don't support websockets, this makes the whole
experience a lot less obnoxious.

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/10484043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b