Issue 10480043: code review 10480043: go.net/websocket: drop old versions of the protocol

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by scottferg

Modified:
10 years, 7 months ago

Reviewers:
ukai

CC:
golang-dev, ukai

Visibility:
Public.

Description

go.net/websocket: drop old versions of the protocol Most modern web browsers support RFC6455, so it's okay to drop older versions. Fixes issue 5628.

Patch Set 2 : diff -r fae782e541a6 https://code.google.com/p/go.net #

Patch Set 3 : diff -r fae782e541a6 https://code.google.com/p/go.net #

Total comments: 2

Patch Set 4 : diff -r fae782e541a6 https://code.google.com/p/go.net #

Patch Set 5 : diff -r fae782e541a6 https://code.google.com/p/go.net #

Patch Set 6 : diff -r fae782e541a6 https://code.google.com/p/go.net #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -158 lines)			Patch
M	websocket/client.go	View	1	1 chunk	+2 lines, -16 lines	0 comments	Download
M	websocket/hybi.go	View	1 2 3	4 chunks	+5 lines, -21 lines	0 comments	Download
M	websocket/hybi_test.go	View	1	2 chunks	+0 lines, -108 lines	0 comments	Download
M	websocket/server.go	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	websocket/websocket.go	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	websocket/websocket_test.go	View	1 2 3 4 5	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

scottferg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.net

10 years, 10 months ago (2013-06-24 03:12:12 UTC) #1

scottferg

Hello golang-dev@googlegroups.com, ukai@google.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 9 months ago (2013-07-22 03:09:48 UTC) #2

ukai

lgtm thanks! https://codereview.appspot.com/10480043/diff/9001/websocket/client.go File websocket/client.go (right): https://codereview.appspot.com/10480043/diff/9001/websocket/client.go#newcode46 websocket/client.go:46: err = hybiClientHandshake(config, br, bw) return error ...

10 years, 9 months ago (2013-07-22 04:00:26 UTC) #3

scottferg

Hello golang-dev@googlegroups.com, ukai@google.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 9 months ago (2013-07-22 16:01:54 UTC) #4

scottferg

https://codereview.appspot.com/10480043/diff/9001/websocket/client.go File websocket/client.go (right): https://codereview.appspot.com/10480043/diff/9001/websocket/client.go#newcode46 websocket/client.go:46: err = hybiClientHandshake(config, br, bw) On 2013/07/22 04:00:26, ukai ...

10 years, 9 months ago (2013-07-22 16:04:03 UTC) #5

scottferg

On 2013/07/22 16:04:03, scottferg wrote: > https://codereview.appspot.com/10480043/diff/9001/websocket/client.go > File websocket/client.go (right): > > https://codereview.appspot.com/10480043/diff/9001/websocket/client.go#newcode46 > ...

10 years, 7 months ago (2013-09-18 22:34:41 UTC) #6

adg

10 years, 7 months ago (2013-09-19 01:04:00 UTC) #7

*** Submitted as
https://code.google.com/p/go/source/detail?r=02bc4e13be96&repo=net ***

go.net/websocket: drop old versions of the protocol

Most modern web browsers support RFC6455, so it's okay to drop older versions.
Fixes issue 5628.

R=golang-dev, ukai
CC=golang-dev
https://codereview.appspot.com/10480043

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages