Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 10478048: code review 10478048: hash: tweak the package docs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by r
Modified:
12 years ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

hash: tweak the package docs No semantic change. I found the wording distracting in a couple of instances and was moved to improve it.

Patch Set 1 #

Total comments: 3

Patch Set 2 : diff -r 41134e67106d https://code.google.com/p/go #

Patch Set 3 : diff -r 41134e67106d https://code.google.com/p/go #

Patch Set 4 : diff -r 41134e67106d https://code.google.com/p/go #

Patch Set 5 : diff -r 41134e67106d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/hash/hash.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years ago (2013-06-24 23:09:42 UTC) #1
bradfitz
https://codereview.appspot.com/10478048/diff/1/src/pkg/hash/hash.go File src/pkg/hash/hash.go (right): https://codereview.appspot.com/10478048/diff/1/src/pkg/hash/hash.go#newcode13 src/pkg/hash/hash.go:13: // (It is declared here by embedding the io.Writer ...
12 years ago (2013-06-24 23:32:47 UTC) #2
r
https://codereview.appspot.com/10478048/diff/1/src/pkg/hash/hash.go File src/pkg/hash/hash.go (right): https://codereview.appspot.com/10478048/diff/1/src/pkg/hash/hash.go#newcode13 src/pkg/hash/hash.go:13: // (It is declared here by embedding the io.Writer ...
12 years ago (2013-06-24 23:37:25 UTC) #3
r
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years ago (2013-06-24 23:37:25 UTC) #4
r
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years ago (2013-06-24 23:40:32 UTC) #5
bradfitz
LGTM
12 years ago (2013-06-24 23:52:12 UTC) #6
r
12 years ago (2013-06-24 23:53:17 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=f6de76ff41a3 ***

hash: tweak the package docs
No semantic change.
I found the wording distracting in a couple of instances and was moved to
improve it.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/10478048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b