Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2408)

Issue 104770047: code review 104770047: armasm: add VFP, golden testdata (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by rsc
Modified:
2 months ago
Reviewers:
minux, cat
CC:
minux
Visibility:
Public.

Description

armasm: add VFP, golden testdata Add VFP instructions, which completes what is used by the Go arm toolchain. Also add tests comparing against testdata. To generate testdata, same as on x86: run exhaustive tests and save the ones that increase the code or table coverage.

Patch Set 1 #

Patch Set 2 : diff -r 08f5d599cb70 https://code.google.com/p/rsc.arm/ #

Patch Set 3 : diff -r 08f5d599cb70 https://code.google.com/p/rsc.arm/ #

Total comments: 6

Patch Set 4 : diff -r 08f5d599cb70 https://code.google.com/p/rsc.arm/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6754 lines, -3884 lines) Patch
M arm.csv View 1 2 7 chunks +29 lines, -27 lines 0 comments Download
M armasm/decode.go View 1 2 9 chunks +96 lines, -0 lines 0 comments Download
A armasm/decode_test.go View 1 1 chunk +69 lines, -0 lines 0 comments Download
M armasm/ext_test.go View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
M armasm/gnu.go View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M armasm/inst.go View 1 2 4 chunks +114 lines, -2 lines 0 comments Download
M armasm/objdump_test.go View 1 2 4 chunks +26 lines, -83 lines 0 comments Download
M armasm/objdumpext_test.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M armasm/tables.go View 1 2 3 chunks +5982 lines, -3695 lines 0 comments Download
A armasm/testdata/Makefile View 1 1 chunk +5 lines, -0 lines 0 comments Download
A armasm/testdata/decode.txt View 1 2 3 1 chunk +306 lines, -0 lines 0 comments Download
M armmap/map.go View 1 2 11 chunks +68 lines, -77 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello minux, I'd like you to review this change to https://code.google.com/p/rsc.arm/
9 years, 4 months ago (2014-06-01 03:03:25 UTC) #1
minux
LGTM. Now I see why ARM instruction decoding is hard when VFP instructions are involved. ...
9 years, 4 months ago (2014-06-01 09:15:07 UTC) #2
rsc
Actually, now that I actually know the details, VFP seems relatively easy. It's the Advanced ...
9 years, 4 months ago (2014-06-01 17:40:28 UTC) #3
rsc
*** Submitted as https://code.google.com/p/rsc/source/detail?r=616aea947362&repo=arm *** armasm: add VFP, golden testdata Add VFP instructions, which completes ...
9 years, 4 months ago (2014-06-01 17:57:30 UTC) #4
cat
2 months ago (2023-07-28 11:45:38 UTC) #5
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b