code review 10476043: misc/notepadplus: fix lose delete keyword

misc/notepadplus: add missing delete keyword

In general the description should describe what is added or fixed, not how it was done (the code does this), but in this case the cause was delete was missing, so the fix is to add it.

Fixes issue 5759.

[chai2010, 2013-06-24 00:38:38]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
http://code.google.com/p/go/

[dave_cheney.net, 2013-06-24 00:48:13]

Thanks for working on this. The description could do with a bit of work, please
consider

misc/notepadplus: add missing delete keyword

In general the description should describe what is added or fixed, not how it
was done (the code does this), but in this case the cause was delete was
missing, so the fix is to add it.

If you edit the description via hg change there title on rietveld and the
subject will be out of sync, don't worry about that, the next hg mail or submit
will fix that. If you edit the description via the web interface, be sure to
update both fields.

[chai2010, 2013-06-24 01:14:53]

On 2013/06/24 00:48:13, dfc wrote:
> Thanks for working on this. The description could do with a bit of work,
please
> consider
> 
> misc/notepadplus: add missing delete keyword
> 
> In general the description should describe what is added or fixed, not how it
> was done (the code does this), but in this case the cause was delete was
> missing, so the fix is to add it.
> 
> If you edit the description via hg change there title on rietveld and the
> subject will be out of sync, don't worry about that, the next hg mail or
submit
> will fix that. If you edit the description via the web interface, be sure to
> update both fields.

Done.

[dave_cheney.net, 2013-06-24 01:18:57]

LGTM. I don't use notepadplus but it looks logical.

If you have not already done so, can you sign the individual CLA. note: there is
no notification that your signature has been received, however when necessary a
googler will review your application and add you to the AUTHORS and CONTRIBUTORS
file.

[chai2010, 2013-06-24 01:24:22]

On 2013/06/24 01:18:57, dfc wrote:
> LGTM. I don't use notepadplus but it looks logical.
> 
> If you have not already done so, can you sign the individual CLA. note: there
is
> no notification that your signature has been received, however when necessary
a
> googler will review your application and add you to the AUTHORS and
CONTRIBUTORS
> file.

I have already sign the individual CLA some days ago.

I see bradfitz has beed created a `A+C: ChaiShushan (individual CLA)`:
https://codereview.appspot.com/10458044/

What to do next?

[dave_cheney.net, 2013-06-24 01:25:29]

Excellent. I'd like someone who uses NP+ to confirm this, or at least
give a second LGTM, then I will submit.

On Mon, Jun 24, 2013 at 11:24 AM,  <chaishushan@gmail.com> wrote:
> On 2013/06/24 01:18:57, dfc wrote:
>>
>> LGTM. I don't use notepadplus but it looks logical.
>
>
>> If you have not already done so, can you sign the individual CLA.
>
> note: there is
>>
>> no notification that your signature has been received, however when
>
> necessary a
>>
>> googler will review your application and add you to the AUTHORS and
>
> CONTRIBUTORS
>>
>> file.
>
>
> I have already sign the individual CLA some days ago.
>
> I see bradfitz has beed created a `A+C: ChaiShushan (individual CLA)`:
> https://codereview.appspot.com/10458044/
>
> What to do next?
>
> https://codereview.appspot.com/10476043/

[chai2010, 2013-06-24 01:27:52]

On 2013/06/24 01:25:29, dfc wrote:
> Excellent. I'd like someone who uses NP+ to confirm this, or at least
> give a second LGTM, then I will submit.
> 
> On Mon, Jun 24, 2013 at 11:24 AM,  <mailto:chaishushan@gmail.com> wrote:
> > On 2013/06/24 01:18:57, dfc wrote:
> >>
> >> LGTM. I don't use notepadplus but it looks logical.
> >
> >
> >> If you have not already done so, can you sign the individual CLA.
> >
> > note: there is
> >>
> >> no notification that your signature has been received, however when
> >
> > necessary a
> >>
> >> googler will review your application and add you to the AUTHORS and
> >
> > CONTRIBUTORS
> >>
> >> file.
> >
> >
> > I have already sign the individual CLA some days ago.
> >
> > I see bradfitz has beed created a `A+C: ChaiShushan (individual CLA)`:
> > https://codereview.appspot.com/10458044/
> >
> > What to do next?
> >
> > https://codereview.appspot.com/10476043/

Thanks!

[Dominik Honnef, 2013-06-24 01:57:04]

LGTM.

Tested before/after, adds delete as a keyword, doesn't break anything.

[dave_cheney.net, 2013-06-24 01:58:39]

Many thanks. Submitting.

On Mon, Jun 24, 2013 at 11:57 AM,  <dominik.honnef@gmail.com> wrote:
> LGTM.
>
> Tested before/after, adds delete as a keyword, doesn't break anything.
>
> https://codereview.appspot.com/10476043/

[dave_cheney.net, 2013-06-24 01:59:14]

Opps, not submitting, still waiting on the A+C.

ping: bradfitz.

On Mon, Jun 24, 2013 at 11:58 AM, Dave Cheney <dave@cheney.net> wrote:
> Many thanks. Submitting.
>
> On Mon, Jun 24, 2013 at 11:57 AM,  <dominik.honnef@gmail.com> wrote:
>> LGTM.
>>
>> Tested before/after, adds delete as a keyword, doesn't break anything.
>>
>> https://codereview.appspot.com/10476043/

[gobot, 2013-06-24 02:00:43]

R=adg (assigned by dfc)

[adg, 2013-06-24 03:28:22]

*** Submitted as https://code.google.com/p/go/source/detail?r=dcd38b375622 ***

misc/notepadplus: add missing delete keyword

In general the description should describe what is added or fixed, not how it
was done (the code does this), but in this case the cause was delete was
missing, so the fix is to add it.

Fixes issue 5759.

R=adg
CC=dave, dominik.honnef, gobot, golang-dev
https://codereview.appspot.com/10476043

Committer: Andrew Gerrand <adg@golang.org>

[chai2010, 2013-06-24 04:22:41]

On 2013/06/24 03:28:22, adg wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=dcd38b375622 ***
> 
> misc/notepadplus: add missing delete keyword
> 
> In general the description should describe what is added or fixed, not how it
> was done (the code does this), but in this case the cause was delete was
> missing, so the fix is to add it.
> 
> Fixes issue 5759.
> 
> R=adg
> CC=dave, dominik.honnef, gobot, golang-dev
> https://codereview.appspot.com/10476043
> 
> Committer: Andrew Gerrand <mailto:adg@golang.org>

hi adg, can i close this code review after submitted?

[dave_cheney.net, 2013-06-24 04:23:39]

hg sync should close the CL, otherwise you can use hg change -D NNNNN
to remove the CL from your list.

On Mon, Jun 24, 2013 at 2:22 PM,  <chaishushan@gmail.com> wrote:
> On 2013/06/24 03:28:22, adg wrote:
>>
>> *** Submitted as
>
> https://code.google.com/p/go/source/detail?r=dcd38b375622 ***
>
>> misc/notepadplus: add missing delete keyword
>
>
>> In general the description should describe what is added or fixed, not
>
> how it
>>
>> was done (the code does this), but in this case the cause was delete
>
> was
>>
>> missing, so the fix is to add it.
>
>
>> Fixes issue 5759.
>
>
>> R=adg
>> CC=dave, dominik.honnef, gobot, golang-dev
>> https://codereview.appspot.com/10476043
>
>
>> Committer: Andrew Gerrand <mailto:adg@golang.org>
>
>
> hi adg, can i close this code review after submitted?
>
>
> https://codereview.appspot.com/10476043/