Refactor to callback services API

Refactor to callback services API



https://code.launchpad.net/~johnsca/charms/trusty/cf-go-router/services-callback-fu/+merge/221443

(do not edit description out of merge proposal)

[johnsca, 2014-05-29 18:29:01]

Please take a look.

[benjamin.saller, 2014-05-29 18:51:20]

LGTM, thanks

https://codereview.appspot.com/104720044/diff/1/hooks/config.py
File hooks/config.py (right):

https://codereview.appspot.com/104720044/diff/1/hooks/config.py#newcode23
hooks/config.py:23: result = subprocess.check_output(['dig', '+short',
'@8.8.8.8', address])
thank you google, there should be a better way, but I've done this too

https://codereview.appspot.com/104720044/diff/1/hooks/config.py#newcode38
hooks/config.py:38: 'ports': [80, 443],
we still expose 443 but its aspirational iirc

[johnsca, 2014-05-29 19:45:19]

On 2014/05/29 18:51:20, benjamin.saller wrote:
> hooks/config.py:23: result = subprocess.check_output(['dig', '+short',
> mailto:, address])
> thank you google, there should be a better way, but I've done this too
> 
> hooks/config.py:38: 'ports': [80, 443],
> we still expose 443 but its aspirational iirc

Yeah, I just moved the existing logic, but it did seem like a strange approach
to me.  I expected juju to provide a way to fetch the IP address instead of the
resolved name.

[johnsca, 2014-05-29 20:23:40]

*** Submitted:

Refactor to callback services API

R=benjamin.saller
CC=
https://codereview.appspot.com/104720044