code review 10468043: test: match gccgo error strings.

test: match gccgo error strings.

[remyoudompheng, 2013-06-26 15:16:13]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-06-26 15:22:57]

LGTM



On Wed, Jun 26, 2013 at 8:16 AM, <remyoudompheng@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> test: match gccgo error strings.
>
> Please review this at
https://codereview.appspot.**com/10468043/<https://codereview.appspot.com/104...
>
> Affected files:
>   M test/const6.go
>   M test/fixedbugs/issue4085a.go
>
>
> Index: test/const6.go
> ==============================**==============================**=======
> --- a/test/const6.go
> +++ b/test/const6.go
> @@ -19,12 +19,12 @@
>         c4 mybool = c2 == (1 < 2)
>         c5 mybool = 1 < 2
>         c6 mybool1 = x < y
> -       c7 = c1 == c2 // ERROR "mismatched types"
> -       c8 = c2 == c6 // ERROR "mismatched types"
> -       c9 = c1 == c6 // ERROR "mismatched types"
> +       c7 = c1 == c2 // ERROR "mismatched types|incompatible types"
> +       c8 = c2 == c6 // ERROR "mismatched types|incompatible types"
> +       c9 = c1 == c6 // ERROR "mismatched types|incompatible types"
>         _ = c2 && (x < y)
>         _ = c2 && (1 < 2)
> -       _ = c1 && c2 // ERROR "mismatched types"
> -       _ = c2 && c6 // ERROR "mismatched types"
> -       _ = c1 && c6 // ERROR "mismatched types"
> +       _ = c1 && c2 // ERROR "mismatched types|incompatible types"
> +       _ = c2 && c6 // ERROR "mismatched types|incompatible types"
> +       _ = c1 && c6 // ERROR "mismatched types|incompatible types"
>  )
> Index: test/fixedbugs/issue4085a.go
> ==============================**==============================**=======
> --- a/test/fixedbugs/issue4085a.go
> +++ b/test/fixedbugs/issue4085a.go
> @@ -9,10 +9,10 @@
>  type T []int
>
>  func main() {
> -       _ = make(T, -1)       // ERROR "negative"
> -       _ = make(T, 0.5)       // ERROR "constant 0.5 truncated to integer"
> -       _ = make(T, 1.0)       // ok
> -       _ = make(T, 1<<63)  // ERROR "len argument too large"
> -       _ = make(T, 0, -1)    // ERROR "negative cap"
> +       _ = make(T, -1)    // ERROR "negative"
> +       _ = make(T, 0.5)   // ERROR "constant 0.5 truncated to
> integer|non-integer len argument"
> +       _ = make(T, 1.0)   // ok
> +       _ = make(T, 1<<63) // ERROR "len argument too large"
> +       _ = make(T, 0, -1) // ERROR "negative cap"
>         _ = make(T, 10, 0) // ERROR "len larger than cap"
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[remyoudompheng, 2013-06-26 16:05:28]

*** Submitted as https://code.google.com/p/go/source/detail?r=d291b354a6d7 ***

test: match gccgo error strings.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/10468043