Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8937)

Issue 10464043: code review 10464043: cmd/gc: fix missing export data for inlining in a few o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by remyoudompheng
Modified:
9 years, 5 months ago
Reviewers:
r, ality
CC:
rsc, golang-dev, ality, r
Visibility:
Public.

Description

cmd/gc: fix missing export data for inlining in a few other cases. Exported inlined functions that perform a string conversion using a non-exported named type may miss it in export data. Fixes issue 5755.

Patch Set 1 #

Patch Set 2 : diff -r 56909cb770fe https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 56909cb770fe https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c590606ee7e5 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
M src/cmd/gc/export.c View 1 1 chunk +5 lines, -0 lines 0 comments Download
A test/fixedbugs/issue5755.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
A test/fixedbugs/issue5755.dir/a.go View 1 1 chunk +60 lines, -0 lines 0 comments Download
A test/fixedbugs/issue5755.dir/main.go View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5
remyoudompheng
Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 5 months ago (2013-06-23 08:56:12 UTC) #1
ality
LGTM There have been a handful of similar fixes. Are there any other ops that ...
9 years, 5 months ago (2013-06-23 10:28:22 UTC) #2
remyoudompheng
On 2013/06/23 10:28:22, ality wrote: > LGTM > > There have been a handful of ...
9 years, 5 months ago (2013-06-28 21:07:02 UTC) #3
r
LGTM
9 years, 5 months ago (2013-06-28 21:08:40 UTC) #4
remyoudompheng
9 years, 5 months ago (2013-06-28 21:29:18 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=c224c549a3c7 ***

cmd/gc: fix missing export data for inlining in a few other cases.

Exported inlined functions that perform a string conversion
using a non-exported named type may miss it in export data.

Fixes issue 5755.

R=rsc, golang-dev, ality, r
CC=golang-dev
https://codereview.appspot.com/10464043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b