Issue 104570043: code review 104570043: runtime: use the nsec system call instead of /dev/binti...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 104570043: code review 104570043: runtime: use the nsec system call instead of /dev/binti... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by aram

Modified:
10 years, 11 months ago

Reviewers:
0intro

CC:
0intro, ality, dave_cheney.net, golang-codereviews, jas, mischief_9.offblast.org, rsc

Visibility:
Public.

Description

runtime: use the nsec system call instead of /dev/bintime on Plan 9

Patch Set 2 : diff -r 690153652172 https://code.google.com/p/go #

Patch Set 3 : diff -r 690153652172 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 690153652172 https://code.google.com/p/go #

Patch Set 5 : diff -r 690153652172 https://code.google.com/p/go #

Patch Set 6 : diff -r fdd2d7a9dd4c https://code.google.com/p/go #

Patch Set 7 : diff -r ba5b861c474f https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
M	src/pkg/runtime/os_plan9.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/os_plan9.c	View	1 2 3	1 chunk	+6 lines, -22 lines	0 comments	Download
M	src/pkg/runtime/sys_plan9_386.s	View	1 2 3 4	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/sys_plan9_amd64.s	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

aram

Hello 0intro (cc: ality, dfc, golang-codereviews@googlegroups.com, jas, mischief@9.offblast.org, rsc), I'd like you to review this ...

10 years, 11 months ago (2014-07-07 13:36:19 UTC) #1

0intro

LGTM https://codereview.appspot.com/104570043/diff/40001/src/pkg/runtime/sys_plan9_386.s File src/pkg/runtime/sys_plan9_386.s (right): https://codereview.appspot.com/104570043/diff/40001/src/pkg/runtime/sys_plan9_386.s#newcode67 src/pkg/runtime/sys_plan9_386.s:67: TEXT runtime·_nsec(SB),NOSPLIT,$0 Could you name the syscall nsec ...

10 years, 11 months ago (2014-07-07 14:54:55 UTC) #2

aram

https://codereview.appspot.com/104570043/diff/40001/src/pkg/runtime/sys_plan9_386.s File src/pkg/runtime/sys_plan9_386.s (right): https://codereview.appspot.com/104570043/diff/40001/src/pkg/runtime/sys_plan9_386.s#newcode67 src/pkg/runtime/sys_plan9_386.s:67: TEXT runtime·_nsec(SB),NOSPLIT,$0 On 2014/07/07 14:54:54, 0intro wrote: > Could ...

10 years, 11 months ago (2014-07-07 18:09:04 UTC) #3

aram

10 years, 11 months ago (2014-07-09 10:33:53 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=0edf43b07381 ***

runtime: use the nsec system call instead of /dev/bintime on Plan 9

LGTM=0intro
R=0intro
CC=ality, dave, golang-codereviews, jas, mischief, rsc
https://codereview.appspot.com/104570043

Expand All Messages | Collapse All Messages