Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(176)

Issue 10456044: code review 10456044: codereview: force hg update after hg pull -u during hg sync (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by rsc
Modified:
11 years, 8 months ago
Reviewers:
dsymonds, bradfitz
CC:
golang-dev, bradfitz, r, dsymonds
Visibility:
Public.

Description

codereview: force hg update after hg pull -u during hg sync If you hg update your client to an earlier CL, then hg sync will move you back to tip if it pulls anything in, but it will leave you where you are if it doesn't pull anything in. That's confusing: make hg sync always update to tip.

Patch Set 1 #

Patch Set 2 : diff -r cbcc3e864275 https://code.google.com/p/go/ #

Patch Set 3 : diff -r cbcc3e864275 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3899cce24466 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M lib/codereview/codereview.py View 1 2 3 2 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 9 months ago (2013-06-21 19:05:25 UTC) #1
bradfitz
LGTM
11 years, 9 months ago (2013-06-21 20:21:45 UTC) #2
r
AHA!
11 years, 9 months ago (2013-06-21 21:21:14 UTC) #3
dsymonds
LGTM++
11 years, 9 months ago (2013-06-22 04:07:10 UTC) #4
rsc
I changed this slightly, to use hg incoming to decide whether to do hg pull ...
11 years, 8 months ago (2013-06-24 18:17:19 UTC) #5
rsc
11 years, 8 months ago (2013-06-25 21:23:27 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=45419f700ae9 ***

codereview: force hg update after hg pull -u during hg sync

If you hg update your client to an earlier CL, then
hg sync will move you back to tip if it pulls anything in,
but it will leave you where you are if it doesn't pull anything in.
That's confusing: make hg sync always update to tip.

R=golang-dev, bradfitz, r, dsymonds
CC=golang-dev
https://codereview.appspot.com/10456044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b