Issue 104550043: Issue 3996: Clarify 'thickness and 'line-thickness property docstrings.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 104550043: Issue 3996: Clarify 'thickness and 'line-thickness property docstrings.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by Mark Polesky

Modified:
9 years, 9 months ago

Reviewers:
marc

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

This has confused me for long enough... http://code.google.com/p/lilypond/issues/detail?id=3996

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -13 lines)			Patch
	M	lily/staff-symbol-referencer-scheme.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
	M	scm/define-grob-properties.scm	View		4 chunks	+24 lines, -9 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

marc

9 years, 9 months ago (2014-07-06 08:20:11 UTC) #1

https://codereview.appspot.com/104550043/diff/20001/scm/define-grob-propertie...
File scm/define-grob-properties.scm (right):

https://codereview.appspot.com/104550043/diff/20001/scm/define-grob-propertie...
scm/define-grob-properties.scm:589: @code{Staff.StaffSymbol.thickness}).")
The decriptions are very instructive, but I find it quite strange
that 'line-thickness' does not refer to grobs made of lines, but rather
to a pen diameter or a contour thickness, whereas 'thickness' mostly
refers to what I'd call 'line-thickness'.

But this is not in the primary scope of your patch, so LGTM.

Expand All Messages | Collapse All Messages