Doc: notation-appendices.itely - added 2 Clefs

Doc: notation-appendices.itely - added 2 Clefs

Added two Clefs to A10 - Clef Styles

\clef "G2" and \clef moderntab

[Mark Polesky, 2014-07-04 07:57:27]

https://codereview.appspot.com/104520043/diff/1/Documentation/notation/notati...
File Documentation/notation/notation-appendices.itely (right):

https://codereview.appspot.com/104520043/diff/1/Documentation/notation/notati...
Documentation/notation/notation-appendices.itely:1489: @tab
For the last two entries, this makes better sense to me:

@tab
@code{\clef tab}
@tab
@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
\new TabStaff {
  \clef tab
  c1
}
@end lilypond

@item
@code{\clef moderntab}
@tab
@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
\new TabStaff {
  \clef moderntab
  c1
}
@end lilypond

[pkx166h, 2014-07-04 10:29:15]

https://codereview.appspot.com/104520043/diff/1/Documentation/notation/notati...
File Documentation/notation/notation-appendices.itely (right):

https://codereview.appspot.com/104520043/diff/1/Documentation/notation/notati...
Documentation/notation/notation-appendices.itely:1489: @tab
On 2014/07/04 07:57:26, Mark Polesky wrote:
> For the last two entries, this makes better sense to me:
> 
> @tab
> @code{\clef tab}
> @tab
> @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
> \new TabStaff {
>   \clef tab
>   c1
> }
> @end lilypond
> 
> @item
> @code{\clef moderntab}
> @tab
> @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
> \new TabStaff {
>   \clef moderntab
>   c1
> }
> @end lilypond

The problem is (else I would have done what you suggested) is that one cannot
just use

\clef moderntab { c1 } and it will print like \clef tab { c1 }, so I was trying
to show that to get that specific clef you must (so it seems) use the \new
TabStaff { .. } construct.

That maybe expected or not, but I felt it a bit misleading to not state that you
cannot use this clef in the same way as the others.

But I don't mind doing that unless anyone has any other input?

[Mark Polesky, 2014-07-04 21:12:38]

On 2014/07/04 10:29:15, J_lowe wrote:
> The problem is (else I would have done what you suggested) is that one cannot
> just use
> 
> \clef moderntab { c1 } and it will print like \clef tab { c1 }, so I was
trying
> to show that to get that specific clef you must (so it seems) use the \new
> TabStaff { .. } construct.

Okay, but "\clef tab" needs "\new TabStaff" as well (right now it's showing 5
lines and a whole note, instead of 6 lines and a fret number).  So then the last
two items look like this:

***************************

@tab
@c @example does not work as expected within multitables
@code{
\new TabStaff @{ @*
@ @ \clef tab @*
@}
}
@tab
@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
\new TabStaff {
  \clef tab
  c1
}
@end lilypond

@item
@c @example does not work as expected within multitables
@code{
\new TabStaff @{ @*
@ @ \clef moderntab @*
@}
}
@tab
@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
\new TabStaff {
  \clef moderntab
  c1
}
@end lilypond

***************************

By the way, in the other items, you could remove all those excess brackets:

@lilypond[line-width=3\cm,notime,ragged-right,relative=1]
\clef G
c1
@end lilypond

[pkx166h, 2014-07-05 05:28:36]

On 2014/07/04 21:12:38, Mark Polesky wrote:
> On 2014/07/04 10:29:15, J_lowe wrote:
> > The problem is (else I would have done what you suggested) is that one
cannot
> > just use
> > 
> > \clef moderntab { c1 } and it will print like \clef tab { c1 }, so I was
> trying
> > to show that to get that specific clef you must (so it seems) use the \new
> > TabStaff { .. } construct.
> 
> Okay, but "\clef tab" needs "\new TabStaff" as well 

Well I've never used Tab notation before and lilypond will let you compile

\clef tab c1

but if you try

\clef moderntab c1

you get a staff but no clef is printed

So if you *always* use a \new TabStaff for \clef tab then fine, I can just write
@code{\clef moderntab} and be done. That was the point I was really making I
guess.


(right now it's showing 5
> lines and a whole note, instead of 6 lines and a fret number).  So then the
last
> two items look like this:
> 
> ***************************
> 
> @tab
> @c @example does not work as expected within multitables
> @code{
> \new TabStaff @{ @*
> @ @ \clef tab @*
> @}
> }
> @tab
> @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
> \new TabStaff {
>   \clef tab
>   c1
> }
> @end lilypond
> 
> @item
> @c @example does not work as expected within multitables
> @code{
> \new TabStaff @{ @*
> @ @ \clef moderntab @*
> @}
> }
> @tab
> @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
> \new TabStaff {
>   \clef moderntab
>   c1
> }
> @end lilypond
> 
> ***************************
> 
> By the way, in the other items, you could remove all those excess brackets:
> 
> @lilypond[line-width=3\cm,notime,ragged-right,relative=1]
> \clef G
> c1
> @end lilypond

Yes I will thanks.

[pkx166h, 2014-07-05 05:50:12]

Mark P's comments addressed

[Mark Polesky, 2014-07-05 09:15:35]

On 2014/07/05 05:28:36, J_lowe wrote:
> > Okay, but "\clef tab" needs "\new TabStaff" as well 
> 
> Well I've never used Tab notation before and lilypond will let you compile
> \clef tab c1

It will let you compile, but the visual output is still wrong.

> So if you *always* use a \new TabStaff for \clef tab then fine, I can just
write
> @code{\clef moderntab} and be done.

I'm sorry if I confused you.  Your original idea of showing the "\new TabStaff"
in a code{} block is preferable, but you *need* to use "\new TabStaff" for both
tab and moderntab.  Just doing "\clef tab c1" (without the "\new TabStaff")
results in the wrong output, as I described in comment #3.  Plus you still have
the excess curly braces in the moderntab lilypond block.  I think your best bet
is to cut and paste the code I provided between the asterisks in comment #3, for
the last two items.

- Mark

[pkx166h, 2014-07-08 19:20:55]

With Mark P's corrections. Thanks.

[pkx166h, 2014-07-08 19:21:18]

Thanks.

[pkx166h, 2014-07-15 16:36:04]

author	James Lowe <pkx166h@gmail.com>	
	Fri, 4 Jul 2014 05:35:06 +0000 (06:35 +0100)
committer	James Lowe <pkx166h@gmail.com>	
	Tue, 15 Jul 2014 16:30:51 +0000 (17:30 +0100)
commit	1f3579b543de896b60d9c11f7a9d51b15612f34c