A little template helper for checking flags.

A little template helper for checking flags.

Rick pointed out that this might be useful down the road, and makes the sharing
code cleaner. So here it is.

https://code.launchpad.net/~jcsackett/juju-gui/handlebars-helper/+merge/170689

Requires: https://code.launchpad.net/~jcsackett/juju-gui/sharing-widget/+merge/170615

(do not edit description out of merge proposal)

[j.c.sackett, 2013-06-20 20:03:25]

Please take a look.

[jeff.pihach, 2013-06-20 20:17:50]

LGTM Thanks for the cleanup, great idea!

https://codereview.appspot.com/10451044/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/10451044/diff/1/app/views/utils.js#newcode1318
app/views/utils.js:1318: 
It's pretty trivial but could you add a small comment here about what it's for
and what is happening wrt the callback.

[j.c.sackett, 2013-06-20 20:18:39]

On 2013/06/20 20:17:50, jeff.pihach wrote:
> LGTM Thanks for the cleanup, great idea!
> 
> https://codereview.appspot.com/10451044/diff/1/app/views/utils.js
> File app/views/utils.js (right):
> 
> https://codereview.appspot.com/10451044/diff/1/app/views/utils.js#newcode1318
> app/views/utils.js:1318: 
> It's pretty trivial but could you add a small comment here about what it's for
> and what is happening wrt the callback.

I can try; there was a comment, but lint kept choking on it in a strange and
obscure way.

[rharding, 2013-06-21 10:58:10]

LGTM

I'm with Jeff on adding method docs to the helper and looks good aside from
that. Thanks for the helper.

[j.c.sackett, 2013-06-24 20:42:27]

*** Submitted:

A little template helper for checking flags.

Rick pointed out that this might be useful down the road, and makes the sharing
code cleaner. So here it is.

R=jeff.pihach, rharding
CC=
https://codereview.appspot.com/10451044