Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2069)

Issue 10449044: state/apiserver/machine: add AgentAPI.SetPasswords

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by rog
Modified:
10 years, 10 months ago
Reviewers:
mue, mp+170788, fwereade
Visibility:
Public.

Description

state/apiserver/machine: add AgentAPI.SetPasswords We also add the client side, and implement it in such a way that it can easily be incorporated into the unit agent API. https://code.launchpad.net/~rogpeppe/juju-core/325-machineagent-api-setpassword/+merge/170788 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver/machine: add AgentAPI.SetPasswords #

Patch Set 3 : state/apiserver/machine: add AgentAPI.SetPasswords #

Patch Set 4 : state/apiserver/machine: add AgentAPI.SetPasswords #

Patch Set 5 : state/apiserver/machine: add AgentAPI.SetPasswords #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -6 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/machineagent/state.go View 3 chunks +23 lines, -0 lines 0 comments Download
M state/api/machineagent/state_test.go View 2 chunks +35 lines, -0 lines 0 comments Download
M state/api/params/params.go View 1 chunk +12 lines, -0 lines 0 comments Download
A state/apiserver/common/export_test.go View 1 chunk +11 lines, -0 lines 0 comments Download
A state/apiserver/common/password.go View 1 chunk +63 lines, -0 lines 0 comments Download
A state/apiserver/common/password_test.go View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
M state/apiserver/machine/agent.go View 3 chunks +9 lines, -4 lines 0 comments Download
M state/apiserver/machine/agent_test.go View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
rog
Please take a look.
10 years, 10 months ago (2013-06-21 11:09:54 UTC) #1
fwereade
LGTM, very nice.
10 years, 10 months ago (2013-06-21 11:19:08 UTC) #2
mue
LGTM
10 years, 10 months ago (2013-06-21 12:31:32 UTC) #3
rog
Please take a look.
10 years, 10 months ago (2013-06-21 13:58:31 UTC) #4
rog
Please take a look.
10 years, 10 months ago (2013-06-21 14:22:49 UTC) #5
rog
10 years, 10 months ago (2013-06-21 14:50:49 UTC) #6
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b