Issue 10444043: Add annotations to service to prevent jumping.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10444043: Add annotations to service to prevent jumping.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by matthew.scott

Modified:
10 years, 10 months ago

Reviewers:
mp+170651, jeff.pihach, benji

Visibility:
Public.

Description

Add annotations to service to prevent jumping. Services would jump to the middle of the canvas in the period of time before the RPC call from juju and the delta containing the updated annotations. This is prevented by preemptively setting the annotations on the service in the RPC callback before the x/y attrs are removed. https://code.launchpad.net/~makyo/juju-gui/svc-jump/+merge/170651 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add annotations to service to prevent jumping. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	app/views/charm-panel.js	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

matthew.scott

10 years, 10 months ago (2013-06-20 17:06:48 UTC) #5

*** Submitted:

Add annotations to service to prevent jumping.

Services would jump to the middle of the canvas in the period of time before the
RPC call from juju and the delta containing the updated annotations.  This is
prevented by preemptively setting the annotations on the service in the RPC
callback before the x/y attrs are removed.

R=gary.poster, jeff.pihach, benji
CC=
https://codereview.appspot.com/10444043

Expand All Messages | Collapse All Messages