Issue 10427043: Fixes onclick from templates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10427043: Fixes onclick from templates

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by sharky93

Modified:
10 years, 11 months ago

Reviewers:
TheSheep

Visibility:
Public.

More Reviews

Patch Set 2 : Fixes unused variables, unnecessary global functions, variables, linter ready. #

Patch Set 3 : Fixes unused variables, unnecessary global functions, variables, linter ready, using objects. #

Total comments: 4

Patch Set 4 : Fix for instance name, prototyping outside document.ready #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -83 lines)			Patch
M	MoinMoin/static/js/common.js	View	1 2 3	11 chunks	+95 lines, -77 lines	0 comments	Download
M	MoinMoin/templates/itemviews.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	MoinMoin/templates/modify.html	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	MoinMoin/templates/utils.html	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

TheSheep

https://codereview.appspot.com/10427043/diff/1/MoinMoin/static/js/common.js File MoinMoin/static/js/common.js (right): https://codereview.appspot.com/10427043/diff/1/MoinMoin/static/js/common.js#newcode57 MoinMoin/static/js/common.js:57: } Move this whole function to line 73, we ...

10 years, 11 months ago (2013-06-19 21:02:48 UTC) #1

TheSheep

10 years, 11 months ago (2013-06-20 20:25:14 UTC) #2

https://codereview.appspot.com/10427043/diff/11003/MoinMoin/static/js/common.js
File MoinMoin/static/js/common.js (right):

https://codereview.appspot.com/10427043/diff/11003/MoinMoin/static/js/common....
MoinMoin/static/js/common.js:595: MoinMoin.prototype.MOINFLASHWARNING =
"moin-flash moin-flash-warning";
define them together with all other methods, no need to put them in the
document.ready

https://codereview.appspot.com/10427043/diff/11003/MoinMoin/static/js/common....
MoinMoin/static/js/common.js:596: var various_utilities = new MoinMoin();
it's logical to call an instance of class MoinMoin moinmoin or moin

https://codereview.appspot.com/10427043/diff/11003/MoinMoin/templates/modify....
File MoinMoin/templates/modify.html (right):

https://codereview.appspot.com/10427043/diff/11003/MoinMoin/templates/modify....
MoinMoin/templates/modify.html:24: {% set shortname = shortname|json_dumps %}
shortname seems to be unused?

https://codereview.appspot.com/10427043/diff/11003/MoinMoin/templates/utils.html
File MoinMoin/templates/utils.html (right):

https://codereview.appspot.com/10427043/diff/11003/MoinMoin/templates/utils.h...
MoinMoin/templates/utils.html:72: <button class="expander" title="{{ _('Expand
Subitem') }}"></button>
shouldn't the class be moin-expander?

Expand All Messages | Collapse All Messages