Issue 10426043: code review 10426043: crypto/x509: add function to marshal EC private keys.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10426043: code review 10426043: crypto/x509: add function to marshal EC private keys. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by agl1

Modified:
12 years ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

crypto/x509: add function to marshal EC private keys. This complements the parsing function that we already have.

Patch Set 2 : diff -r 9ab9ac0001a0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9ab9ac0001a0 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 9ab9ac0001a0 https://code.google.com/p/go/ #

Patch Set 5 : diff -r b2560a1d1e52 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	src/pkg/crypto/x509/sec1.go	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download
	M	src/pkg/crypto/x509/sec1_test.go	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-06-19 20:49:08 UTC) #1

https://codereview.appspot.com/10426043/diff/5001/src/pkg/crypto/x509/sec1.go File src/pkg/crypto/x509/sec1.go (right): https://codereview.appspot.com/10426043/diff/5001/src/pkg/crypto/x509/sec1.go#newcode36 src/pkg/crypto/x509/sec1.go:36: func MarshalECPrivateKey(key *ecdsa.PrivateKey) ([]byte, error) { comment please, simple ...

12 years ago (2013-06-19 20:54:41 UTC) #2

agl1

12 years ago (2013-06-19 20:58:44 UTC) #3

agl1

12 years ago (2013-06-20 16:14:24 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=53d90932fe34 ***

crypto/x509: add function to marshal EC private keys.

This complements the parsing function that we already have.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10426043

Expand All Messages | Collapse All Messages