Issue 10417043: Test and fix bug #1191981.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10417043: Test and fix bug #1191981.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by niemeyer

Modified:
11 years, 5 months ago

Reviewers:
mp+170372, rog

Visibility:
Public.

Description

Test and fix bug #1191981. https://code.launchpad.net/~niemeyer/goyaml/fix-1191981/+merge/170372 (do not edit description out of merge proposal)

Patch Set 2 : Test and fix bug #1191981. #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -15 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	apic.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	decode_test.go	View	2 chunks	+28 lines, -4 lines	0 comments	Download
M	scannerc.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	yamlprivateh.go	View	3 chunks	+6 lines, -6 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

*** Submitted: Test and fix bug #1191981. R= CC= https://codereview.appspot.com/10417043

11 years, 5 months ago (2013-06-19 14:26:47 UTC) #2

rog

https://codereview.appspot.com/10417043/diff/3001/yamlprivateh.go File yamlprivateh.go (right): https://codereview.appspot.com/10417043/diff/3001/yamlprivateh.go#newcode117 yamlprivateh.go:117: return ( // is_break: how about changing all of ...

11 years, 5 months ago (2013-06-19 14:57:59 UTC) #3

niemeyer

11 years, 5 months ago (2013-06-19 14:58:39 UTC) #4

On 2013/06/19 14:57:59, rog wrote:
> https://codereview.appspot.com/10417043/diff/3001/yamlprivateh.go
> File yamlprivateh.go (right):
> 
> https://codereview.appspot.com/10417043/diff/3001/yamlprivateh.go#newcode117
> yamlprivateh.go:117: return (        // is_break:
> how about changing all of these to omit the brackets?
> 
> return b[i] == '\r' ||
>    etc

That's unrelated to this fix. I've just run go fmt.

Expand All Messages | Collapse All Messages