Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90)

Issue 10413044: code review 10413044: cmd/go: put the coverage information on the summary line. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by r
Modified:
12 years ago
Reviewers:
adg, rsc
CC:
adg, golang-dev
Visibility:
Public.

Description

cmd/go: put the coverage information on the summary line. Output now: ok crypto/aes 0.060s coverage: 89.8% of statements ok crypto/des 0.074s coverage: 92.2% of statements ok crypto/dsa 0.056s coverage: 34.5% of statements ok crypto/ecdsa 0.058s coverage: 86.8% of statements ok crypto/elliptic 0.039s coverage: 94.6% of statements ok crypto/hmac 0.037s coverage: 93.5% of statements ok crypto/md5 0.031s coverage: 96.2% of statements ok crypto/rand 0.074s coverage: 9.9% of statements ok crypto/rc4 0.090s coverage: 66.7% of statements ok crypto/rsa 0.253s coverage: 83.5% of statements

Patch Set 1 #

Patch Set 2 : diff -r 7e6f9b9091c4 https://code.google.com/p/go #

Patch Set 3 : diff -r 53d90932fe34 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/cmd/go/test.go View 1 2 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years ago (2013-06-19 17:02:21 UTC) #1
adg
12 years ago (2013-06-20 01:07:34 UTC) #2
adg
LGTM
12 years ago (2013-06-20 01:07:39 UTC) #3
r
*** Submitted as https://code.google.com/p/go/source/detail?r=733157d9f33d *** cmd/go: put the coverage information on the summary line. Output ...
12 years ago (2013-06-20 17:27:50 UTC) #4
rsc
12 years ago (2013-06-21 17:11:43 UTC) #5
Message was sent while issue was closed.
LGTM

Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b